-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Change coordinates to reflectometry coordinate system #14
Comments
@jokasimr Is this still relevant with the recent rewrite? |
Yes it is still relevant. But I'm not sure if we want to do anything about it. It would make using the coordinate transformation code in scippneutron more complicated. Essreflectometry uses a global coordinate system similar to the rest of the instrument workflows. That is, sample is origin, z is the 'beam direction' (this becomes fuzzy when it comes to instruments with focusing like amor and estia, but it's basically the vector from sample to the the detector, projected to the horizontal plane), y is up, and x is whatever is left. |
Is there a way to avoid referring to x, y, z at all, e.g., by callings things |
This can mask some differences. But there is a fundamental difference between reflectometry and the other techniques. Normally, we define
But in reflectometry it seems that people use
|
Currently an internal (or maybe NeXus) standard is used for what is
x
,y
, andz
. This doesn't work for reflectometry where there is already an accepted standard that depends on the sample orientation (see https://orsopy.readthedocs.io/en/latest/orsopy.fileio.base.html#orsopy.fileio.base.ValueVector). The Amor code should be modified to adhere to this reflectometry standard.The text was updated successfully, but these errors were encountered: