Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support replacing providers based on their key, i.e., their return value #57

Closed
SimonHeybrock opened this issue Sep 14, 2023 · 0 comments · Fixed by #90
Closed

Support replacing providers based on their key, i.e., their return value #57

SimonHeybrock opened this issue Sep 14, 2023 · 0 comments · Fixed by #90
Assignees

Comments

@SimonHeybrock
Copy link
Member

After using Sciline for a little, it has become evident that (as anticipated) we need a more convenient way of replacing providers. There are two options:

  • Remove the checks in __setitem__, set_provider, ... which prevent replacements. Note that this may be tricky, since we can have parameters, providers, generic providers, as well as param tables. That is, care must be taken (and a lot of tests be written).
  • Simpler options: Provide dict-like helpers to store providers prior to pipeline creation. Users can currently word around this by writing a simple as_dict function that parses the return type hints and uses them as keys.
@SimonHeybrock SimonHeybrock moved this from Next to Selected in Development Board Dec 6, 2023
@SimonHeybrock SimonHeybrock self-assigned this Dec 19, 2023
@SimonHeybrock SimonHeybrock moved this from Selected to In progress in Development Board Dec 19, 2023
@github-project-automation github-project-automation bot moved this from In progress to Done in Development Board Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

1 participant