Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Documentation with links to type aliases? #61

Closed
SimonHeybrock opened this issue Oct 4, 2023 · 4 comments · Fixed by scipp/copier_template#124 or #110
Closed

Documentation with links to type aliases? #61

SimonHeybrock opened this issue Oct 4, 2023 · 4 comments · Fixed by scipp/copier_template#124 or #110
Assignees

Comments

@SimonHeybrock
Copy link
Member

The following is not really a problem of Sciline itself, it does however severely impact usability of documentation of downstream projects.

Sphinx, in particular with https://github.com/tox-dev/sphinx-autodoc-typehints, "expands" type hints to aliases defined with typing.NewType. That is, instead of a link to the docs of the alias, we just get a long to NewType (which is useless) and the name of the alias.

According to tox-dev/sphinx-autodoc-typehints#216 (comment) this might be intentional. Can this be changed in the extension as suggested in the comment? Do we need our own extension?

@YooSunYoung
Copy link
Member

YooSunYoung commented Dec 19, 2023

I would like to work on it since it affects the documentation of ess* packages.

There are still a lot to discuss about this issue... I'll work on it later...

@YooSunYoung YooSunYoung self-assigned this Dec 19, 2023
@YooSunYoung YooSunYoung removed their assignment Jan 4, 2024
@jl-wynen jl-wynen self-assigned this Jan 11, 2024
@jl-wynen jl-wynen moved this from Next to Selected in Development Board Jan 11, 2024
@jl-wynen jl-wynen moved this from Selected to In progress in Development Board Jan 11, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Development Board Jan 12, 2024
@SimonHeybrock
Copy link
Member Author

Not sure this should be closed: While we have a solution in our copier_template now, this is not readily available or usable by other Sciline users. Maybe we can add this approach to the Sciline docs, or maybe you have a better idea?

@jl-wynen
Copy link
Member

I was only thinking about internal users. So having it in the template would automatically apply this to all packages at some point.

If we want to provide it to other users, too, we should implement a sphinx plugin. Though I'm not sure how that would interact with autodoc.

@SimonHeybrock
Copy link
Member Author

Not saying we have to necessarily provide such a solution, but maybe we should either keep this issue open, or add a docs section?

@SimonHeybrock SimonHeybrock reopened this Jan 15, 2024
@github-project-automation github-project-automation bot moved this from Done to In progress in Development Board Jan 15, 2024
@github-project-automation github-project-automation bot moved this from In progress to Done in Development Board Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
3 participants