Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add integration testing loading real files #131

Closed
SimonHeybrock opened this issue Feb 15, 2022 · 4 comments
Closed

Add integration testing loading real files #131

SimonHeybrock opened this issue Feb 15, 2022 · 4 comments
Assignees

Comments

@SimonHeybrock
Copy link
Member

SimonHeybrock commented Feb 15, 2022

  • Load with both scn.load and scn.load_nexus. scippnexus.v2
  • Existing files (various facilities).
  • Files generated by McStas (+Mantid)
  • Can we use Nexus constructor? https://github.com/ess-dmsc/nexus-constructor
  • Can this run on GitHub? Or too expensive / too much data?
@SimonHeybrock
Copy link
Member Author

One way to verify results could be to save a "reference" using scipp's HDF5 I/O. If we add more features to the loader we may need to update it, but at least it should catch regressions (e.g., failing to load logs that were previously loaded).

@SimonHeybrock
Copy link
Member Author

SimonHeybrock commented Apr 18, 2023

Note that test that load files without verification have recently been added under pytest -m externalfile.

Blocked by scipp/scipp#3056.

@SimonHeybrock SimonHeybrock transferred this issue from scipp/scippneutron Apr 18, 2023
@SimonHeybrock SimonHeybrock moved this from Selected to Blocked in Development Board Apr 18, 2023
@SimonHeybrock
Copy link
Member Author

I have begun adding some manual tests in #133. The approach could be extended.

@SimonHeybrock SimonHeybrock moved this from Blocked to Selected in Development Board May 2, 2023
@SimonHeybrock SimonHeybrock moved this from Selected to Next in Development Board Aug 30, 2023
@SimonHeybrock SimonHeybrock moved this from Next to Blocked in Development Board Oct 12, 2023
@nvaytet nvaytet self-assigned this Jun 10, 2024
@nvaytet
Copy link
Member

nvaytet commented Sep 25, 2024

Is this now more or less covered by the dmsc integration testing?

@github-project-automation github-project-automation bot moved this from Blocked to Done in Development Board Sep 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

No branches or pull requests

2 participants