-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Wrong winner detected #11
Comments
I'll try to find some time to take a look, but it would be helpful if we knew what the underlying issue is. |
Hey @scopatz, I tried to figure it out as well. It looks strange to me. It looks like, as if there is no proper leave event and thus, the lib considers the wrong player as a winner. But im unsure. Maybe we can pair on that? |
Yeah, I think that is true, IIRC. PRs very welcome here |
Cool! Any hints on how to tackle it? |
Update: I digged a lot deeper and figured, that "result()" is incorrectly reporting "lost" for the player who won. But from here, its very tight to the actual w3g format where im not that confident in... Edit @scopatz if you have any ideas based on my recent findings, just shoot (= You probably know more than I do! |
Hello,
I am having an issue with the winner detection. Lady Risa replay tool detects the correct winner, but this lib detects the wrong winner. This is the example replay:
replay
Winner should be player Tapion, but at least in my tests the lib detects the wrong winner.
Is this something that could be fixed anytime soon?
The text was updated successfully, but these errors were encountered: