Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong winner detected #11

Closed
kungfoolfighting opened this issue Oct 14, 2020 · 5 comments · Fixed by #12
Closed

Wrong winner detected #11

kungfoolfighting opened this issue Oct 14, 2020 · 5 comments · Fixed by #12

Comments

@kungfoolfighting
Copy link

Hello,

I am having an issue with the winner detection. Lady Risa replay tool detects the correct winner, but this lib detects the wrong winner. This is the example replay:
replay
Winner should be player Tapion, but at least in my tests the lib detects the wrong winner.

Is this something that could be fixed anytime soon?

@scopatz
Copy link
Owner

scopatz commented Oct 14, 2020

I'll try to find some time to take a look, but it would be helpful if we knew what the underlying issue is.

@SantoDE
Copy link
Contributor

SantoDE commented Oct 20, 2020

Hey @scopatz,

I tried to figure it out as well. It looks strange to me. It looks like, as if there is no proper leave event and thus, the lib considers the wrong player as a winner. But im unsure. Maybe we can pair on that?

@scopatz
Copy link
Owner

scopatz commented Oct 20, 2020

Yeah, I think that is true, IIRC. PRs very welcome here

@SantoDE
Copy link
Contributor

SantoDE commented Oct 20, 2020

Cool! Any hints on how to tackle it?

@SantoDE
Copy link
Contributor

SantoDE commented Oct 20, 2020

Update: I digged a lot deeper and figured, that "result()" is incorrectly reporting "lost" for the player who won. But from here, its very tight to the actual w3g format where im not that confident in...

Edit @scopatz if you have any ideas based on my recent findings, just shoot (= You probably know more than I do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants