Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove Scrapy dependency #3

Closed
kmike opened this issue Apr 29, 2015 · 3 comments
Closed

remove Scrapy dependency #3

kmike opened this issue Apr 29, 2015 · 3 comments

Comments

@kmike
Copy link
Member

kmike commented Apr 29, 2015

Selectors shouldn't import from Scrapy, otherwise splitting them to a separate library doesn't provide benefits.

@pablohoffman
Copy link
Member

nor we should duplicate code.

(incidentally, that's how w3lib got born - we needed common code from both scrapy and scrapely).

will we need to start yet another library? :-/

@eliasdorneles
Copy link
Member

So, we ended up duplicating some utils, only: https://github.com/scrapy/parsel/blob/master/parsel/utils.py

Does someone wants to offer an alternative or are we fine with that an I can close this issue? :)

@dangra
Copy link
Member

dangra commented Jul 31, 2015

We can move more code into w3lib but for now the Scrapy dependency is removed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants