Use extensions to share color and shape between some blocks #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rachel-fenichel
requested review from
ericrosenbaum and
paulkaplan
and removed request for
ericrosenbaum
|
WOOT 🥇 |
rachel-fenichel
added a commit
that referenced
this pull request
Jun 14, 2017
marisaleung
pushed a commit
to marisaleung/scratch-blocks
that referenced
this pull request
Jun 19, 2017
marisaleung
pushed a commit
to marisaleung/scratch-blocks
that referenced
this pull request
Jun 19, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an example of how to use Blockly's extensions framework to share common block attributes. In this case I'm using it for colors for a few categories, as well as for statement blocks.
I'm sure I didn't do the greatest job on naming. I'm happy to change the extension names (and even the extension file + namespace) to the scratchier names.