Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom SecureString converter in PSGSuite breaks other implementations of SecureString usage with Configuration module #236

Closed
scrthq opened this issue Sep 25, 2019 · 0 comments
Assignees
Labels
bug P1 Priority 1: High

Comments

@scrthq
Copy link
Member

scrthq commented Sep 25, 2019

Describe the bug
A clear and concise description of what the bug is.

To Reproduce
Steps to reproduce the behavior:

  1. Import another module that uses Configuration, i.e. PSProfile.
  2. Add a SecureString value to that module's configuration.
  3. Import PSGSuite
  4. Save the other module's configuration
  5. Other module's configuration now shows the SecureString converter function as 'Secure' instead of the default function ConvertTo-SecureString set by Configuration itself.

Expected behavior
PSGSuite should use the same converter function that Configuration itself uses by default.

Screenshots
image

Additional context
This will need to be tested to ensure compatibility with existing PSGSuite configurations, as it stores most of it's values as SecureStrings.

@scrthq scrthq added the bug label Sep 25, 2019
@scrthq scrthq self-assigned this Sep 25, 2019
@scrthq scrthq added the P1 Priority 1: High label Sep 25, 2019
@scrthq scrthq mentioned this issue Sep 27, 2019
scrthq added a commit that referenced this issue Sep 27, 2019
## 2.33.0 - 2019-09-26

* [Issue #236](#236)
  * Fixed: Custom converter for Configuration metadata defaults to `ConvertTo-SecureString` as the preferred function instead of the custom `Secure`. `Secure` is still supported for backwards compatibility.
@scrthq scrthq closed this as completed Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug P1 Priority 1: High
Projects
None yet
Development

No branches or pull requests

1 participant