Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoordinateSystem.axes_names -> CoordinateSystem.axis_names #67

Open
kevinyamauchi opened this issue Dec 11, 2022 · 2 comments
Open

CoordinateSystem.axes_names -> CoordinateSystem.axis_names #67

kevinyamauchi opened this issue Dec 11, 2022 · 2 comments

Comments

@kevinyamauchi
Copy link
Collaborator

I think it makes more sense grammar-wise to if we call them CoordinateSystem.axis_namesinstead ofCoordinateSystem.axes_names`.

@ivirshup
Copy link
Member

I think the CoordinateSystems should have a public axes parameter to just get the axes. Not sure why this is private at the moment.

But then, I think I like:

cs.axes
cs.axes_names

Better than:

cs.axes
cs.axis_names

@LucaMarconato
Copy link
Member

LucaMarconato commented Jul 9, 2024

@melonora and I agree with @ivirshup, so we just need to

  • add axes() to the NgffCoordinateSystem class.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants