Expose Timezone._utcoffset property for pandas compatibility #485
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit allows pandas to get _utcoffset from a Timezone object, taking the transision as seen from utcnow.
As explained by @sdispater in the issues linked below, pandas tries to access the
Timezone._utcoffset
property (which isn't currently implemented for variable Timezone objects) and subsequently tries to getTimezone.utcoffset(None)
(which correctly returns None as it can't be determined without knowlede of date and time). This PR allows pandas to treat Timezones as if they were FixedTimezones (as returned for utcnow).ref:
https://github.com/pandas-dev/pandas/blob/v1.0.5/pandas/_libs/tslibs/timezones.pyx#L152
Fixes pandas-dev/pandas#15986
Closes #131
Pull Request Check List
Left this unticked, as it's a private property that users won't touch.