Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

MockRedis does not implement #close #162

Closed
nickstanish opened this issue May 8, 2019 · 1 comment · Fixed by #163
Closed

MockRedis does not implement #close #162

nickstanish opened this issue May 8, 2019 · 1 comment · Fixed by #163
Labels
enhancement

Comments

@nickstanish
Copy link
Contributor

nickstanish commented May 8, 2019 •
edited
Loading

Redis-rb supports close and disconnect!

https://github.com/redis/redis-rb/blob/03e70f323400bb6e87653bec6eb62b43725d5f28/lib/redis.rb#L72-L76
@sds
Copy link
Owner

sds commented May 8, 2019

Should be an easy pull request. Can you make one? It'll be similar to https://github.com/sds/mock_redis/pull/159/files

@sds sds added the enhancement label May 8, 2019
@nickstanish nickstanish mentioned this issue May 8, 2019
Merged
@sds sds closed this as completed in #163 May 8, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Implement close and disconnect nickstanish/mock_redis
2 participants
@sds @nickstanish