Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remapping modifier keys breaks existing modifier key shortcuts #753

Closed
5 tasks done
lucabalsanelli opened this issue Jul 29, 2021 · 13 comments
Closed
5 tasks done

Remapping modifier keys breaks existing modifier key shortcuts #753

lucabalsanelli opened this issue Jul 29, 2021 · 13 comments
Assignees
@sds100
Labels
bug Something isn't working

Comments

@lucabalsanelli
Copy link

lucabalsanelli commented Jul 29, 2021 •
edited by sds100
Loading

Developer TODO (don't remove)

  • create new branch. put issue number at start of name if not a very quick fix.
  • write tests. put issue number in comment
  • update documentation
  • squash and merge
  • delete branch

Describe the bug
SHIFT+LARROW (ie select previous character) , SHIFT+RARROW (ie select next character) not working if there are TRIGGER/ACTION pairs involving SHIFT. Notice that installing KeyMapperKeyboard does not change the problem.

To Reproduce
Steps to reproduce the behavior:

  • create a trigger/action pair involing SHIFT
  • try to select text with SHIFT+LARROW or SHIFT+RARROW

Expected behavior
Previous or next character to be selected as if any other keyboard other than KeyMapper Basic Input is chosen as Input Keyboard or as if pairs involving SHIFT not present or disabled.

Smartphone (please complete the following information):

Additional context
2.3.0 Beta 4 affected and also 2.2.0

REPORT

key_mapper_report_20210729-124151.zip
@lucabalsanelli lucabalsanelli added the bug Something isn't working label Jul 29, 2021
@GL513
Copy link
Contributor

GL513 commented Jul 29, 2021

Just LG G7 or LG G7 ThinQ?
My brother has an LG G7 ThinQ, so i can ask him to test it on that as well.

@lucabalsanelli
Copy link
Author

LG G7 ThinQ. Notice I'm facing the issue with an external mini keyboard (Rii i4 Bluetooth physical mini keyboars with Italian layout), but I guess it's not connected with the keyboard itself. Probably any other physical keyboard with arrows would replicate the issue.

I tried to create a trigger/action pair involving CTRL+2 mapping to 'b' and CTRL+LARROW (move cursor to beginning of line) kept on working. Same for ALT+LARROW.

@GL513
Copy link
Contributor

GL513 commented Jul 30, 2021

LG G7 ThinQ. Notice I'm facing the issue with an external mini keyboard (Rii i4 Bluetooth physical mini keyboars with Italian layout), but I guess it's not connected with the keyboard itself. Probably any other physical keyboard with arrows would replicate the issue.

I tried to create a trigger/action pair involving CTRL+2 mapping to 'b' and CTRL+LARROW (move cursor to beginning of line) kept on working. Same for ALT+LARROW.

Mabey try mapping it to your volume buttons, and see if you get the same result.
I have a generic bluetooth keyboard, and i have to take it apart to see the model, but i get different results with the keyboard compared to the volume buttons. Since your phone is around 3 or 4 years old (the manufacturing/build date) it might preform differently than a newer phone.
Also, if this is a bug on the device end, not the app itself, it might never get fixed, as LG ended their phone line, and only supports bug/security fixes, which i presume will rarely come out, like mabey once every 6 months to a year.
Again, ill test this woth my brother's phone.

@lucabalsanelli
Copy link
Author

A workaround would be to map some other combination involving LARROW but not SHIFT to a 'Select previous character' action (same for RARROW and 'Select next character'). The problem is that I cannot find a way to do that. Among the Actions -> Other -> Keyboard I find CUT, COPY, PASTE and SELECT WORD AT CURSOR. The latter isn't the right thing (it selects the whole word plus following whitespace) since I just want to select the previous or next character, possibly repeatedly with a single long press until I release the keys.

I dont see how it can be a bug on the phone side but everything is possible. I should try using another bluetooth keyboard to see what happens if I find one to borrow.

@lucabalsanelli
Copy link
Author

Today I tried with another phone, precisely

Xiaomi Mi 10T M2007J3SY
MIUI Global 12.0.11 Stable
Android 10 QKQ1.200419.002 patch 2

and the issue it's exactly as with my LG G7 Thinq as described above.

Notice that I tried also creating a Trigger/Action pairr involving CTRL+A printing 'b' and the other functionalities involving CTRL (like copy and paste) stayed functional. The same does not happen with SHIFT.

sds100 added a commit that referenced this issue Oct 1, 2021
@sds100
#753 fix: triggers with modifier keys would break other modifier keyb…
f3b67a2 
…oard shortcuts
@sds100
Copy link
Collaborator

sds100 commented Oct 1, 2021

keymapper-2.4.0-alpha-debug.zip

@lucabalsanelli Can you try this apk? I think it should have fixed it

@lucabalsanelli
Copy link
Author

lucabalsanelli commented Oct 4, 2021 via email

@lucabalsanelli
Copy link
Author

lucabalsanelli commented Oct 15, 2021 via email

@sds100
Copy link
Collaborator

sds100 commented Nov 7, 2021

@lucabalsanelli Okay, so there is already a solution to this problem and it is not obvious, even to me. 😂 You need to turn on this option for the trigger keys that are modifier keys (ctrl, shift etc). I will change the app so it automatically turns this option on for modifier keys and show a brief explanation of why it is necessary. Would renaming it to "do not remap" be better? If this app was designed specifically for keyboards then this option wouldn't exist and it would be handled automatically.

Screenshot_20211107-141215_Key_Mapper_Debug

@sds100
Copy link
Collaborator

sds100 commented Nov 7, 2021

Can you confirm that this fixes your issues?

@sds100 sds100 changed the title Selecting not working w/ SHIFT+LARROW or SHIFT+RARROW if other SHIFT triggers active Remapping modifier keys breaks existing modifier key shortcuts Nov 7, 2021
@lucabalsanelli
Copy link
Author

lucabalsanelli commented Nov 7, 2021 via email

@sds100
Copy link
Collaborator

sds100 commented Nov 7, 2021

Yeah I totally agree, please make those feature requests. It took me a while to figure out this issue because if you want to create key maps with modifier keys then Key Mapper must NOT override the modifier keys. Otherwise it breaks the other modifier keyboard shortcuts. I try to make Key Mapper automatically guess what you are trying to do but a lot of things still need to be configured yourself, which is a "feature" but also makes it more difficult to do simple things than if the app was specialised for a particular task.

sds100 added a commit that referenced this issue Jan 31, 2022
@sds100
#753 fix: Remapping modifier keys breaks existing modifier key shortc…
e0339ca 
…uts so automatically enable the "do not remap" trigger key option for modifier keys
sds100 added a commit that referenced this issue Jan 31, 2022
@sds100
#753 fix: Remapping modifier keys breaks existing modifier key shortc…
ba6d96b 
…uts so automatically enable the "do not remap" trigger key option for modifier keys
@sds100
Copy link
Collaborator

sds100 commented Jan 31, 2022

fixed

@sds100 sds100 closed this as completed Jan 31, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sds100 sds100

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@sds100 @lucabalsanelli @GL513