Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Metal Performance Shaders when training SDV synthesizers on Apple Silicon machines #1966

Open
liuup opened this issue Apr 27, 2024 · 4 comments
Labels
feature request Request for a new feature

Comments

@liuup
Copy link

liuup commented Apr 27, 2024

Problem Description

I have saw the CUDA support in SDV, but it only works on Nvidia GPU. Mac with Apple Silicon now have MPS backend to accelerate the computing process. Could SDV R&D team consider to add the support of MPS?

Some offical docs may help:
Apple: https://developer.apple.com/metal/pytorch/
PyTorch: https://pytorch.org/docs/master/notes/mps.html

@liuup liuup added feature request Request for a new feature new Automatic label applied to new issues labels Apr 27, 2024
@srinify
Copy link
Contributor

srinify commented May 9, 2024

Hi there @liuup 👋

This is a neat idea and I'll leave this open as a feature request! We are a small team so we appreciate your patience as we triage the different requests. We will typically prioritize based on demand and importance to your use case.

To help us prioritize this one, it would be great it if you could describe more about your project. Which synthesizer you're using, what you plan to do with the synthetic data, etc. 🙏

@srinify srinify added under discussion Issue is currently being discussed and removed new Automatic label applied to new issues labels May 9, 2024
@srinify srinify removed the under discussion Issue is currently being discussed label May 21, 2024
@srinify srinify changed the title Could SDV add the support of Apple MPS backend Use Apple's Metal Performance Shaders when training SDV synthesizers on Apple Silicon machines May 21, 2024
@srinify srinify changed the title Use Apple's Metal Performance Shaders when training SDV synthesizers on Apple Silicon machines Use Metal Performance Shaders when training SDV synthesizers on Apple Silicon machines May 21, 2024
@TiStef
Copy link

TiStef commented Jul 12, 2024

Hi there @liuup 👋

This is a neat idea and I'll leave this open as a feature request! We are a small team so we appreciate your patience as we triage the different requests. We will typically prioritize based on demand and importance to your use case.

To help us prioritize this one, it would be great it if you could describe more about your project. Which synthesizer you're using, what you plan to do with the synthetic data, etc. 🙏

Good morning srinify,
same issue here. Particularly when using CTGAN, having torch.backend.mps added as GPU option would be REALLY helpful. Should be an easy fix which would enlarge SDV library to whoever code with Apple Silicon terminals.
Thank you so much for your great work and support

@yawetse
Copy link

yawetse commented Jan 1, 2025

@TiStef I added a pull request for CTGAN with Apple Metal support here: sdv-dev/CTGAN#425

@liuup
Copy link
Author

liuup commented Jan 2, 2025

@TiStef I added a pull request for CTGAN with Apple Metal support here: sdv-dev/CTGAN#425

Hi, I think this is helpful for this repo, I hope the code could be checked by maintainers and merged into main branch! Thanks for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature request Request for a new feature
Projects
None yet
Development

No branches or pull requests

4 participants