Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrating buildah into sealer to make image module stable #1581

Closed
justadogistaken opened this issue Jul 13, 2022 · 0 comments
Closed

Integrating buildah into sealer to make image module stable #1581

justadogistaken opened this issue Jul 13, 2022 · 0 comments
Labels
kind/feature Category issues or PRs related to feature request priority/high Very important, need to be worked with soon but not very urgent

Comments

@justadogistaken
Copy link
Member

justadogistaken commented Jul 13, 2022

Type: feature request

Issue Description(Motivation)

Currently, sealer build/push/pull image by itself, it makes sealer often fails. And some info of sealer image can't be exhibited in imagehub normally.

Nowdays, we have to refactor the image module based on some mature libraries.for fixing image-relevant issues. And it's urgent to make sealer image structure stable. now that the oci image format specification had been made long time ago, and there are several professional tools of building oci-image, why not just use it?

Describe what feature you want

Core Function From Buildah

func BuildDockerfiles(ctx context.Context, store storage.Store, options define.BuildOptions, paths ...string) (id string, ref reference.Canonical, err error)

There is a core function from buildah, and we can call this function to get an oci-image. But this method support Four instructions only. FROM/RUN/ADD/COPY.
So it's incompatible with [Proposal] A more k8s-based/rootfs-transparent instructions in Kubefile. Then we may need to develop a semantic translator to generate final Kubefile for being compatible with more instructions of sealer.

@justadogistaken justadogistaken added kind/feature Category issues or PRs related to feature request priority/high Very important, need to be worked with soon but not very urgent labels Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature Category issues or PRs related to feature request priority/high Very important, need to be worked with soon but not very urgent
Projects
None yet
Development

No branches or pull requests

2 participants