fix: estimatedFeeToMaxFee with integers only

starknet-io · Apr 8, 2022 · 71d19a7 · 71d19a7
1 parent 50a7951
commit 71d19a7
Show file tree

Hide file tree

Showing 3 changed files with 29 additions and 11 deletions.
diff --git a/__tests__/utils/utils.test.ts b/__tests__/utils/utils.test.ts
@@ -77,3 +77,13 @@ describe('computeHashOnElements()', () => {
     );
   });
 });
+describe('estimatedFeeToMaxFee()', () => {
+  test('should return maxFee for 0', () => {
+    const res = stark.estimatedFeeToMaxFee(0, 0.15).toNumber();
+    expect(res).toBe(0);
+  });
+  test('should return maxFee for 10_000', () => {
+    const res = stark.estimatedFeeToMaxFee(10_000, 0.15).toNumber();
+    expect(res).toBe(11_500);
+  });
+});
diff --git a/package-lock.json b/package-lock.json
diff --git a/src/utils/stark.ts b/src/utils/stark.ts
@@ -51,5 +51,7 @@ export function compileCalldata(args: RawArgs): Calldata {
 }
 
 export function estimatedFeeToMaxFee(estimatedFee: BigNumberish, overhead: number = 0.15): BN {
-  return toBN(estimatedFee).mul(toBN(overhead).add(toBN(1)));
+  // BN can only handle Integers, so we need to do all calulations with integers
+  const overHeadPercent = Math.round((1 + overhead) * 100);
+  return toBN(estimatedFee).mul(toBN(overHeadPercent)).div(toBN(100));
 }