Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Web Store warnings and Manifest v3 #239

Open
zplan opened this issue Aug 1, 2024 · 2 comments
Open

Chrome Web Store warnings and Manifest v3 #239

zplan opened this issue Aug 1, 2024 · 2 comments

Comments

@zplan
Copy link

zplan commented Aug 1, 2024

The extension is currently shown as not compatible with Manifest v3 and therefore deactivated soon.
Would it be possible to migrate the extension to make it Manifest v3 compatible?

@seansfkelley
Copy link
Owner

I'm open to it and would accept a PR, as long as it continues to be compatible with both Firefox and Chromium-based browsers (which might be a little annoying since one demands service workers and the other background pages, though maybe just specifying both will Just Work?). I'm unlikely to address this myself in the near future due to time contraints.

@seansfkelley
Copy link
Owner

As of just a couple weeks ago it looks like Firefox is implementing the combination of v2 and v3 features, so it seems like this extension should be able to switch to v3 and have everything just work in all browsers, since it doesn't use any v2-only features. That would still require a bit of a rewrite to service workers, but the extension already uses async communication protocols with the common background page so architecturally it should be pretty similar.

I still don't have enough time to dig into this myself, but would test/merge/release a PR that does it.

@seansfkelley seansfkelley changed the title Possible migration to Manifest V3? Chrome store warnings and manifest v3 Mar 4, 2025
@seansfkelley seansfkelley changed the title Chrome store warnings and manifest v3 Chrome Web Store warnings and Manifest v3 Mar 4, 2025
@seansfkelley seansfkelley pinned this issue Mar 4, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants