Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autocomplete Banner subProps #304

Closed
dkonieczek opened this issue Jan 7, 2022 · 0 comments · Fixed by #305 or #306
Closed

Autocomplete Banner subProps #304

dkonieczek opened this issue Jan 7, 2022 · 0 comments · Fixed by #305 or #306
Assignees
@dkonieczek

Comments

@dkonieczek
Copy link
Contributor

The Autocomplete component is not passing down banner subProps

Need to add {...subProps.banner} to all Banner components within the Autocomplete component:

{!hideBanners ? <Banner {...subProps.banner} content={merchandising.content} type={BannerType.HEADER} /> : null}
@dkonieczek dkonieczek self-assigned this Jan 7, 2022
@dkonieczek dkonieczek linked a pull request Jan 7, 2022 that will close this issue
fix(autocomplete): pass down banner subProps #305
Merged
@dkonieczek dkonieczek mentioned this issue Jan 7, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dkonieczek dkonieczek

Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@dkonieczek