Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version 7.0 #285

Closed
97 tasks done
twelch opened this issue May 9, 2024 · 2 comments
Closed
97 tasks done

Version 7.0 #285

twelch opened this issue May 9, 2024 · 2 comments
Assignees

Comments

@twelch
Copy link
Contributor

twelch commented May 9, 2024

Other

  • Migrate to ES Module structure/runtime - Node 20, Vite, Vitest, Storybook 8 #272
  • Remove translation:extract from prepare
  • Fix clear-all-results command
  • make script names consistent (e.g. install:scripts, translation:install)
  • Remove any project-space files that can be removed (babel? if translation:extract goes internal)
  • Remove leftover jest references, and use of group directives`
  • Update clipToGeography with latest enhancements in california-reports
  • Add prettier (include project config json files).
  • Add eslint. Fix all error. Then add lint-staged.
  • baseLangResourcez debug logging
  • Deprecate clip function, for turf
  • start-data to start:data
  • Remove loadCogWindow and loadCog
  • Remove any other past deprecated
  • Change toSketchProperties array to toChildProperties,
  • make sure genSketch creates within eez, loop and check until true
  • raster import is just geotiff, don't ask what formats the user wants.
  • Simplify fsm example data, precalc taking forever
  • Remove template-ocean-eez?
  • simplify reef extent and benthic dataset in project
  • rename genRandomFeature to genRandomPolygon
  • Fix SimpleCard squiggle error with area
  • add unit tests to preprocessor function and mock calls to cloudfront vectordatasource
  • make sure on upgrade that clipToGeography is updated.
  • Create a new page for CoralReefCard and BenthicHabitatCard in sampleProject?
  • don't require geojson file for geography import on precalc
  • Ask abby do we really need ${datasourceId}_all check is in vectorFunction? Is there another way to get what you want here? Is it a feature or a one-off? Something to be added by example if the user needs it?
  • refactor precalc to use loadFgbFromDisk function
  • migrate fs.rmDirSync to fs.rm
  • incorporate getFeaturesForSketchBBoxes into getFeatures? #386
  • refactor overlapFeatures
  • add tests to removeOverlap and toMultipolygon
  • unpin aws-cdk version, allow it to upgrade
  • bump to node22 in cdk

Abby

  • Every new project has a certain little warning in test output, unclear what is causing this #385
    • error polygon1 ValidationError: Feature is outside of boundary
      at Module.clipToPolygonFeatures (file:///workspaces/test-three/node_modules/@seasketch/geoprocessing/src/toolbox/genPreprocessor.ts:155:11)
      at clipToOceanEez (/workspaces/test-three/src/functions/clipToOceanEez.ts:52:10)
  • Fix clear results by report
  • filter list in question - Select additional feature properties to keep in final datasource - using answer to last question
  • Test migrate California

Other Dependencies

  • Upgrade deps, minimize npm install warnings
    • Drop deprecated request dependency for fetch with form data
  • Add peer? dependencies so that projects know what versions to upgrade to?
  • Allow user to select which languages to support in project and filter the list in supported.ts.
  • Better support (bring in helper functions).

Bugs

  • project package.json version is getting set to the version of gp on install. It should be left as I think 0.1
  • lint-staged getting removed from project package.json on upgrade

Improve upgrade

  • Consolidate config into project dir - src/i18n/config.json, geoprocessing.json
  • Write upgrade script - include first install of scripts, then translation, merge extraTerms, merge package.json dependencies/scripts ,vscode dir, etc.
  • If already have dependency, remove from devDependency

AWS

i18n

  • Verify extractExtraTerms script is working properly
  • Update core translations. Make full POEditor cycle is working
  • Upgrade react-i18n major upgrade
  • translation:install should check if top-level i18n files all exist including config.json (user may have wiped it out) and copy over if not.
  • publish latest translations and rerun for languages

React

  • React version 18

Test Tooling

Document

  • Document minimum migration steps for any given release - run all install scripts, update dependency versions to at least what is in base-project and whatever template you used.
  • How to run tests, no more smoke or unit specific for projects
  • use of npm-check-updates -- ncu --interactive --format group
  • how to do a prerelease. after first one have to select "custom prerelease" to advance it.
  • Review and update migration steps, including package.json list
  • Document run of translation:extract in tutorial now that is not run automatically on each npm install
  • Add link to release on front page.
  • Document how to run individual smoke tests, how to debug in vscode
  • How to use lambda worker helper function
  • clear:result and start:data
  • Clarify that user can add new language code manually
  • upgrade clarify that will overwrite files and directories
  • Drop the notion of codespaces
  • Rollback docs for 6.1.0 - report templates, and updates to importing datasources, fetching layers and attributes to select from as opposed to typing them out
  • Fix sketchAttributes.md links
  • Remove toNullSketch from defaults
  • Add create:report doc and any other, next to CLI page.
  • move all the ways of linking data to a sub-page. Tutorial can just use FSM example data.
  • Import raster is asking vector questions in 6.1.2, make sure not in 7.0
  • Pull the extra metric group examples (fishRichness etc.) out to a metric group guide in 7.0
  • Recommend devcontainer for Mac, WSL Ubuntu for Windows,
    • How to copy files to devcontainer on Windows?
    • What does Abby do on a mac
  • add polygonSmokeTest function
  • update antimeridian page to account for new functions and fixes
  • Add wsl distribution publish steps to Contributing
  • Make sure data linking is up to date, including how to mount Box drive in macOS
  • document "the right way" to do a simple intersect using geoprocessing. Look at genPreprocessor, it has best way to do an intersect and a difference.
  • Update metric group examples
  • Drop geography code from simple reports, leave in createReport.
  • Document setting of environment before aws deploy
  • drop mention of macos support
  • disable the old wiki
  • link toolbox page commands to their api docs
  • Update version 7 migration steps, pulling from previous betas.
  • how to copy to/from datasets bucket directly
  • Write toolbox unit tests. make sure that union is like a dissolve

Tutorial

  • Make sure registering of stories is consistent across examples. Why was a top-level CoralReef report client created?

Release Testing

  • Init new project
  • Verify translation is setup and works properly, remoteContext is set to project name
  • Test all preprocessors
  • Deploy and test full report migration in SeaSketch
  • Delete all test stacks deployed
  • gp-workspace Windows release

Follow-on tickets:

  • Drop basic.json, migrate languages property to geoprocessing.json #395
  • document datasource filters and such and getDatasourceFeatures
  • document, my geoprocessing function is too slow, what do I do?
    • Subdivide your data, use getFeaturesForSketchBBox, look into functions like clipMultiMerge, increase Lambda memory up to 10GB, use workers, simplify your data.
  • publish both a sync and async version of simpleFunction calculating area of the sketch on a fresh stack and see how they compare first run and thereafter both cached and uncached
  • Verify sample tutorial results in QGIS
  • If import extension is fgb or shp then don't need to ask for layer name, just use basename of file
  • add more tests to getFeaturesForSketchBboxes, tests to the split bbox functions
  • migrate getDatasourceFeatures.test.ts to be e2e and use locally served fgb like flatgeobuf.test.e2e.ts and getFeatures.test.ts. Drop subdivided/VectorDataSource datasources in src/project/datasources.json and use global-datasources instead.
  • deploy command is using npx, which runs the latest cdk instead of what geoprocessing has installed. how to specify local?
  • prettier is not working by default, what's up. extensions are they asked to be installed recommended?
  • rasterStats could get a solveOverlap option that assumes sketches don't overlap and sums the
  • add overlapPoints (montserrate reports)
  • The datasource format name of "subdivided" is a mistake. any format can have subdivided polygons, that's not what makes VectorDataSource unique.
  • website doc location in folders don't quite align with where pages are in the sidebar hierarchy. Some of the names aren't clear like top-level page in Tutorials.md but it's more specific than that.
@avmey
Copy link
Contributor

avmey commented Dec 11, 2024

@twelch Looking into your bullet filter list in question - Select additional feature properties to keep in final datasource - using answer to last question. You may have already addressed it, unless I'm misunderstanding the suggestion. It seems like the list already filters out variables that were selected in the previous question

@twelch
Copy link
Contributor Author

twelch commented Dec 31, 2024

Closed via 74b41c2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

2 participants