optimize MessageType and TransactionErrorCode #453
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #453 +/- ##
=======================================
Coverage 39.05% 39.05%
=======================================
Files 144 144
Lines 9120 9120
=======================================
Hits 3562 3562
Misses 5264 5264
Partials 294 294 Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
luky116
reviewed
Jan 8, 2023
| */ | ||
| MessageTypeGlobalCommit MessageType = 7 | ||
| MessageTypeBranchCommit |
There was a problem hiding this comment.
之前顺序是乱的,我调整了下,方便用iota
| */ | ||
| MessageTypeBranchStatusReport MessageType = 13 | ||
| MessageTypeGlobalLockQuery MessageType = iota + 3 |
There was a problem hiding this comment.
这里iota是递增上面的,上面的一行是iota是17,这个MessageTypeGlobalLockQuery值应该是21,中间没有其他连续的枚举值了,所以加了3
106umao
changed the title
luky116
approved these changes
Feb 11, 2023
georgehao
approved these changes
Feb 12, 2023
georgehao
pushed a commit
to georgehao/seata-go
that referenced
this pull request
May 7, 2023
format MessageType and TransactionErrorCode
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does:
Optimize MessageType and TransactionErrorCode
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: