reactor:multiple update executor #481

VaderKai · 2023-02-14T08:34:55Z

What this PR does:
refactor pkg/datasource/sql/undo/builder to pkg/datasource/sql/exec/at

Which issue(s) this PR fixes:

Fixes #439

Special notes for your reviewer:

Does this PR introduce a user-facing change?:

pkg/datasource/sql/exec/at/multi_update_excutor.go

luky116 · 2023-02-14T16:39:04Z

在seata-go-sample项目中跑通了，再提交，这样能避免很多问题

Issues-translate-bot · 2023-02-14T16:39:18Z

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

After running through the seata-go-sample project, submit it again, which can avoid many problems

VaderKai · 2023-02-15T06:00:56Z

在seata-go-sample项目中跑通了，再提交，这样能避免很多问题

好嘞，我下次注意下哈哈

Issues-translate-bot · 2023-02-15T06:01:07Z

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

After running through the seata-go-sample project, submit it again, which can avoid many problems

Alright, I'll pay attention next time haha

luky116 · 2023-02-15T07:25:07Z

在seata-go-sample项目中跑通了，再提交，这样能避免很多问题

好嘞，我下次注意下哈哈

辛苦大佬哈

Issues-translate-bot · 2023-02-15T07:25:19Z

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

After running through the seata-go-sample project, submit it again, which can avoid many problems

Alright, I'll pay attention next time haha

hard work boss

luky116 · 2023-02-15T07:25:33Z

在seata-go-sample项目中跑通了，再提交，这样能避免很多问题

好嘞，我下次注意下哈哈

请问大佬大名？

Issues-translate-bot · 2023-02-15T07:25:45Z

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

After running through the seata-go-sample project, submit it again, which can avoid many problems

Alright, I'll pay attention next time haha

May I ask the big guy's name?

codecov-commenter · 2023-02-15T07:29:38Z

Codecov Report

Merging #481 (b495268) into master (cf5661e) will decrease coverage by 0.45%.
The diff coverage is 23.91%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##           master     #481      +/-   ##
==========================================
- Coverage   39.02%   38.57%   -0.45%     
==========================================
  Files         145      147       +2     
  Lines        9638     9949     +311     
==========================================
+ Hits         3761     3838      +77     
- Misses       5565     5793     +228     
- Partials      312      318       +6

Impacted Files	Coverage Δ
pkg/datasource/sql/exec/at/at_executor.go	`0.00% <0.00%> (ø)`
pkg/datasource/sql/exec/at/multi_executor.go	`0.00% <0.00%> (ø)`
pkg/datasource/sql/exec/at/multi_update_excutor.go	`32.35% <32.35%> (ø)`

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Issues-translate-bot · 2023-02-15T08:17:44Z

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

I'm Weide hahaha

VaderKai · 2023-02-15T08:17:56Z

在seata-go-sample项目中跑通了，再提交，这样能避免很多问题

好嘞，我下次注意下哈哈

请问大佬大名？

我是唯德哈哈哈

Issues-translate-bot · 2023-02-15T08:18:08Z

RoBot detected the issue body's language is not English, translate it automatically. 👯👭🏻🧑‍🤝‍🧑👫🧑🏿‍🤝‍🧑🏻👩🏾‍🤝‍👨🏿👬🏿

After running through the seata-go-sample project, submit it again, which can avoid many problems

Okay, I'll pay attention next time haha

May I ask the big guy's name?

I'm Weide hahaha

pkg/datasource/sql/exec/at/multi_executor.go

pkg/datasource/sql/exec/at/multi_executor_test.go

pkg/datasource/sql/exec/at/multi_update_excutor.go

pkg/datasource/sql/exec/at/multi_executor.go

pkg/datasource/sql/exec/at/multi_executor_test.go

pkg/constant/symbol.go

…re/multi_update

luky116 · 2023-02-18T08:56:36Z

跑了下，发现beforeImage和afterImage的值相同

{
    "xid":"192.168.51.106:8091:2612448039579227740",
    "branchId":2612448039579227753,
    "sqlUndoLogs":[
        {
            "sqlType":"MULTI",
            "tableName":"order_tbl",
            "beforeImage":{
                "tableName":"order_tbl",
                "sqlType":"MULTI",
                "rows":[
                    {
                        "fields":[
                            {
                                "keyType":"NULL",
                                "name":"descs",
                                "type":12,
                                "value":"NewDescs-1676710380505"
                            },
                            {
                                "keyType":"PRIMARY_KEY",
                                "name":"id",
                                "type":4,
                                "value":1
                            }
                        ]
                    },
                    {
                        "fields":[
                            {
                                "keyType":"NULL",
                                "name":"descs",
                                "type":12,
                                "value":"NewDescs-1676710380505"
                            },
                            {
                                "keyType":"PRIMARY_KEY",
                                "name":"id",
                                "type":4,
                                "value":2
                            }
                        ]
                    }
                ]
            },
            "afterImage":{
                "tableName":"order_tbl",
                "sqlType":"MULTI",
                "rows":[
                    {
                        "fields":[
                            {
                                "keyType":"NULL",
                                "name":"descs",
                                "type":12,
                                "value":"NewDescs-1676710380505"
                            },
                            {
                                "keyType":"PRIMARY_KEY",
                                "name":"id",
                                "type":4,
                                "value":1
                            }
                        ]
                    },
                    {
                        "fields":[
                            {
                                "keyType":"NULL",
                                "name":"descs",
                                "type":12,
                                "value":"NewDescs-1676710380505"
                            },
                            {
                                "keyType":"PRIMARY_KEY",
                                "name":"id",
                                "type":4,
                                "value":2
                            }
                        ]
                    }
                ]
            }
        },
        {
            "sqlType":"MULTI",
            "tableName":"order_tbl",
            "beforeImage":{
                "tableName":"order_tbl",
                "sqlType":"MULTI",
                "rows":[
                    {
                        "fields":[
                            {
                                "keyType":"NULL",
                                "name":"descs",
                                "type":12,
                                "value":"NewDescs-1676710380505"
                            },
                            {
                                "keyType":"PRIMARY_KEY",
                                "name":"id",
                                "type":4,
                                "value":1
                            }
                        ]
                    },
                    {
                        "fields":[
                            {
                                "keyType":"NULL",
                                "name":"descs",
                                "type":12,
                                "value":"NewDescs-1676710380505"
                            },
                            {
                                "keyType":"PRIMARY_KEY",
                                "name":"id",
                                "type":4,
                                "value":2
                            }
                        ]
                    }
                ]
            },
            "afterImage":{
                "tableName":"order_tbl",
                "sqlType":"MULTI",
                "rows":[
                    {
                        "fields":[
                            {
                                "keyType":"NULL",
                                "name":"descs",
                                "type":12,
                                "value":"NewDescs-1676710380505"
                            },
                            {
                                "keyType":"PRIMARY_KEY",
                                "name":"id",
                                "type":4,
                                "value":1
                            }
                        ]
                    },
                    {
                        "fields":[
                            {
                                "keyType":"NULL",
                                "name":"descs",
                                "type":12,
                                "value":"NewDescs-1676710380505"
                            },
                            {
                                "keyType":"PRIMARY_KEY",
                                "name":"id",
                                "type":4,
                                "value":2
                            }
                        ]
                    }
                ]
            }
        }
    ]
}

luky116 · 2023-02-18T08:50:14Z

pkg/datasource/sql/exec/at/multi_executor.go

+}
+
+// ExecContext exec SQL, and generate before image and after image
+func (m *multiExecutor) ExecContext(ctx context.Context, f exec.CallbackWithNamedValue) (types.ExecResult, error) {


ExecContext 里面，直接判断该使用 MultiUpdateExeCutor 还是使用 MultiDeleteExeCutor，然后直接使用 executor.ExecContext() 方法。下面的beforeImage和afterImage方法就可以用都删了。这里没有逻辑的话，以后应该会更好维护

pkg/datasource/sql/exec/at/at_executor.go

* reactor:multiple update executor

reactor:multiple update executor

053c513

github-actions bot added the coding label Feb 14, 2023

reactor:multiple update executor

da553c8

baerwang reviewed Feb 14, 2023

View reviewed changes

pkg/datasource/sql/exec/at/multi_update_excutor.go Outdated Show resolved Hide resolved

luky116 reviewed Feb 14, 2023

View reviewed changes

fix:multiple update executor code review

7fa450e

github-actions bot added the module/rm label Feb 15, 2023

VaderKai added 5 commits February 15, 2023 17:09

reactor:multiple executor

7ff8c65

reactor:multiple executor

b617b82

reactor:multiple executor

5fe48b4

reactor:multiple executor

6af1da4

reactor:multiple executor test

516077b

wang1309 reviewed Feb 16, 2023

View reviewed changes

baerwang reviewed Feb 17, 2023

View reviewed changes

pkg/datasource/sql/exec/at/multi_update_excutor.go Outdated Show resolved Hide resolved

fix:logic error

1666ea3

luky116 reviewed Feb 18, 2023

View reviewed changes

pkg/datasource/sql/exec/at/multi_executor.go Outdated Show resolved Hide resolved

pkg/datasource/sql/exec/at/multi_executor_test.go Outdated Show resolved Hide resolved

pkg/constant/symbol.go Outdated Show resolved Hide resolved

Merge branch 'master' into feature/multi_update

62448d5

VaderKai added 2 commits February 18, 2023 15:17

fix:logic error

923aea0

Merge remote-tracking branch 'origin/feature/multi_update' into featu…

177396d

…re/multi_update

luky116 reviewed Feb 18, 2023

View reviewed changes

VaderKai and others added 2 commits February 19, 2023 12:05

fix:beforeImage same to afterImage

7ac2c8a

Merge branch 'master' into feature/multi_update

87aab1d

github-actions bot removed the module/rm label Feb 19, 2023

luky116 approved these changes Feb 20, 2023

View reviewed changes

jasondeng1997 approved these changes Feb 20, 2023

View reviewed changes

iSuperCoder reviewed Feb 20, 2023

View reviewed changes

pkg/datasource/sql/exec/at/at_executor.go Outdated Show resolved Hide resolved

reactor:multiple executor test

bb7e0ea

wang1309 approved these changes Feb 20, 2023

View reviewed changes

reactor:multiple executor test

b495268

iSuperCoder approved these changes Feb 20, 2023

View reviewed changes

luky116 merged commit 5326e7f into apache:master Feb 20, 2023

VaderKai deleted the feature/multi_update branch February 20, 2023 16:02

luky116 mentioned this pull request Mar 11, 2023

add undo executor for multi update sql #476

Closed

georgehao pushed a commit to georgehao/seata-go that referenced this pull request May 7, 2023

reactor: multiple update executor (apache#481)

abbb2b1

* reactor:multiple update executor

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

reactor:multiple update executor #481

reactor:multiple update executor #481

VaderKai commented Feb 14, 2023

luky116 commented Feb 14, 2023

Issues-translate-bot commented Feb 14, 2023

VaderKai commented Feb 15, 2023

Issues-translate-bot commented Feb 15, 2023

luky116 commented Feb 15, 2023

Issues-translate-bot commented Feb 15, 2023

luky116 commented Feb 15, 2023

Issues-translate-bot commented Feb 15, 2023

codecov-commenter commented Feb 15, 2023 •

edited

Loading

Issues-translate-bot commented Feb 15, 2023

VaderKai commented Feb 15, 2023

Issues-translate-bot commented Feb 15, 2023

luky116 commented Feb 18, 2023

luky116 Feb 18, 2023

reactor:multiple update executor #481

reactor:multiple update executor #481

Conversation

VaderKai commented Feb 14, 2023

luky116 commented Feb 14, 2023

Issues-translate-bot commented Feb 14, 2023

VaderKai commented Feb 15, 2023

Issues-translate-bot commented Feb 15, 2023

luky116 commented Feb 15, 2023

Issues-translate-bot commented Feb 15, 2023

luky116 commented Feb 15, 2023

Issues-translate-bot commented Feb 15, 2023

codecov-commenter commented Feb 15, 2023 • edited Loading

Codecov Report

Issues-translate-bot commented Feb 15, 2023

VaderKai commented Feb 15, 2023

Issues-translate-bot commented Feb 15, 2023

luky116 commented Feb 18, 2023

luky116 Feb 18, 2023

Choose a reason for hiding this comment

codecov-commenter commented Feb 15, 2023 •

edited

Loading