-
Notifications
You must be signed in to change notification settings - Fork 285
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ftr:integrate test #535
Ftr:integrate test #535
Conversation
Codecov Report
📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more @@ Coverage Diff @@
## master #535 +/- ##
==========================================
- Coverage 38.64% 36.65% -1.99%
==========================================
Files 152 160 +8
Lines 10250 11133 +883
==========================================
+ Hits 3961 4081 +120
- Misses 5963 6705 +742
- Partials 326 347 +21 see 66 files with indirect coverage changes Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
.github/workflows/integrate-test.yml
Outdated
strategy: | ||
matrix: | ||
golang: | ||
- 1.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
项目中用的 1.18,最好统一一下
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
项目中用的 1.18,最好统一一下
已改
.github/workflows/integrate-test.yml
Outdated
- name: "set up go" | ||
uses: actions/setup-go@v3 | ||
with: | ||
go-version: 1.19 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
同上
已改
integrate_test.sh
Outdated
echo "github pull request head branch -> ${GITHUB_HEAD_REF}" | ||
|
||
echo "use seata-go-samples $3 branch for integration testing" | ||
git clone -b ftr/integrate_test https://github.com/seata/seata-go-samples samples && cd samples |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这里的 ftr/integrate_test 分支未来是否还会存在?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
这个搞错了,已经删掉了 直接master就可以了
feat add integrate_test
What this PR does:
集成测试的脚本,自动加载sample下面的integrate_test,检测当前代码是否有问题
Which issue(s) this PR fixes:
Fixes #
Special notes for your reviewer:
Does this PR introduce a user-facing change?: