Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Backward incompatible change in PHPUnit 6.5 #2892

Closed
frederikbosch opened this issue Dec 1, 2017 · 2 comments
Closed

Backward incompatible change in PHPUnit 6.5 #2892

frederikbosch opened this issue Dec 1, 2017 · 2 comments

Comments

@frederikbosch
Copy link

Q A
PHPUnit version 6.5.0
PHP version 7.1.12
Installation Method Composer

Version 6.5.0 contains backward incompatible changes due to the upgrade of phpunit-mock-objects from version 4 to 5. See bug report #388 in that repository. Since the functionality of that library is directly available in PHPUnit, version 6.5.0 should have been version 7.0.0. And since it is not, more users will hit the problem. Therefore I think it should be at least considered to reverse to the old behaviour.

@weierophinney
Copy link

I can confirm; see this job: https://travis-ci.org/zendframework/zend-session/jobs/310112861

In that build, the lockfile is pinned to a 6.2 series phpunit and 5.0 series of phpunit-mock-objects. The linked job does a composer update, which pulls in PHPUnit 6.5.1 and phpunit-mock-objects 5.0.2, and I then get two errors due to missing interfaces used in typehints.

I attempted aliasing the 4.0.1 interface name to the 5.0.2 interface name, but then had signature errors instead.

I'd argue that PHPUnit 6.5 should continue pinning to the phpunit-mock-objects 4 series.

@sebastianbergmann
Copy link
Owner

Duplicate of sebastianbergmann/phpunit-mock-objects#388

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants