Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows build fails a test #17

Closed
oranja opened this issue Jun 6, 2017 · 2 comments
Closed

Windows build fails a test #17

oranja opened this issue Jun 6, 2017 · 2 comments

Comments

@oranja
Copy link

oranja commented Jun 6, 2017

Hi,
Until now I was using Zipper on GNU/Linux and it worked well, but now I tried to build Zipper on a Windows 10 machine for the first time, and it seems to work, except for this one failing test:

C:\Projects\lib\zipper\build>libZipper-test.exe

~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
libZipper-test.exe is a Catch v1.5.6 host application.
Run with -? for options

-------------------------------------------------------------------------------
Scenario: zipfile feed with different inputs
     Given: A Zip outputed to a file
      When: a file containing 'test file compression' is added and named
            'test1'
      Then: the zip file has one entry named 'test1.txt'
       And: extracting the test1.txt entry creates a file named 'test1.txt'
            with the text 'test file compression'
  And when: another file containing 'other data to compression test' and named
            'test2.dat' is added inside a folder 'TestFolder'
       And: the zip file has two entrys named 'test1.txt' and 'TestFolder/test2
            .dat'
       And: extracting the test2.dat entry creates a folder 'TestFolder' with a
            file named 'test2.dat' with the text 'other data to compression
            test'
  And when: adding a folder to the zip, creates one entry for each file inside
            the folder with the name in zip as 'Folder/...'
-------------------------------------------------------------------------------
C:\Projects\lib\zipper\test\file_zip_test.cpp(15)
...............................................................................

C:\Projects\lib\zipper\test\file_zip_test.cpp(105): FAILED:
  {Unknown expression after the reported line}
due to unexpected exception with message:
  invalid string position

===============================================================================
test cases:  2 |  1 passed | 1 failed
assertions: 50 | 49 passed | 1 failed

With a little help from debug prints, I can say that the exception is thrown from this call:
test/file_zip_test.cpp : 124 : zipper.add("TestFiles");


* To clarify, this is from master, without any of my changes from #16.
* Everything (Zipper, zlib 1.2.11) was compiled for x64, with MSVC 19 (VS 14.0 / 2015).

Here is the CMake summary:

--
----------------------------------------------------------------------
Zipper version 0.9.1
----------------------------------------------------------------------

   Configured on host ''
     host type                       = Windows
     host operating system           = Windows 10.0.14393
     host CPU architecture           = AMD64

   General build flags:
     CC                              = C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64/cl.exe
     CXX                             = C:/Program Files (x86)/Microsoft Visual Studio 14.0/VC/bin/amd64/cl.exe
     CPPFLAGS                        =  -D_CRT_SECURE_NO_WARNINGS
     CFLAGS                          = /DWIN32 /D_WINDOWS /W3
     CXXFLAGS                        = /DWIN32 /D_WINDOWS /W3 /GR /EHsc
     LDFLAGS                         = /machine:x64

   Zlib library configuration:
     Zlib library                    = C:/Program Files/zlib/lib/zlib.lib
     Zlib include dir                = C:/Program Files/zlib/include

   Other configuration settings:
     Installation $prefix            = C:/Program Files/zipper

-- Configuring done
-- Generating done
-- Build files have been written to: C:/Projects/lib/zipper/build
@filonik
Copy link
Contributor

filonik commented Jul 24, 2017

My pull request (#18) should fix that.

@sebastiandev
Copy link
Owner

sebastiandev commented Jul 24, 2017

This should be fixed as per @filonik PR (already merged). Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants