Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missing CSS class feedbackBorderERROR for FormComponentFeedbackBorder component #344

Open
tverdokhlebd opened this issue Mar 29, 2022 · 4 comments

Comments

@tverdokhlebd
Copy link

CSS class "feedbackBorderERROR" is missing for FormComponentFeedbackBorder component in Wicket 9.x version.
Wicket 8 uses just inline-style "style="color:red;", however wicket 9 uses CSS class "feedbackBorderERROR" that cannot be found.

@martin-g
Copy link
Collaborator

The idea in the change in Wicket 9.x is to use this CSS class as a "placeholder".
It should be provided by the application depending on its UI requirements.

But maybe libraries like Wicket jQuery UI and Wicket Bootstrap should/could provide it as well, since they provide UI styling already.

@sebfz1
Copy link
Owner

sebfz1 commented Mar 29, 2022 via email

@tverdokhlebd
Copy link
Author

Thanks for the answers.
I just wanted to say that moving from Wicket 8 to Wicket 9 should not break behavior for this component.
I expected that this style class will contain red color for default behavior.

@martin-g
Copy link
Collaborator

Some people prefer red border for the input, others red hint text or red asterisk next to the input field, other people prefer a floating red-ish box in to appear at the top of the window, ...
Wicket uses SemVer and the upgrade from 8.x to 9.x is the perfect time to make such breaking (behavior) changes!
Unfortunately https://cwiki.apache.org/confluence/display/WICKET/Migration+to+Wicket+9.0 does not mention it! :-(

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants