Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blind_inv_ in oprf.h #446

Open
maths644311798 opened this issue Dec 11, 2024 · 1 comment
Open

blind_inv_ in oprf.h #446

maths644311798 opened this issue Dec 11, 2024 · 1 comment
Assignees

Comments

@maths644311798
Copy link
Contributor

(1) In yacl/crypto/aead/aead.h,
The annotation “AEAD: Authenticated Encryption And Decryption” is not precise. It should be “AEAD: Authenticated Encryption with Associated Data”.

(2) In oprf/oprf.h,

if (blind_inv_ != 0_mp) {
      MPInt::InvertMod(blind_, ec->GetOrder(), &blind_inv_);
}

looks strange. Should it be if (blind_inv_ == 0_mp)? It seems that blind_inv_ is always 0 in the current program.

@changtong9
Copy link

You are right, we will fix it soon.
Thanks for your comments.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants