Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

G402 doesn't catch all cases #908

Closed
leonklingele opened this issue Jan 7, 2023 · 1 comment · Fixed by #911
Closed

G402 doesn't catch all cases #908

leonklingele opened this issue Jan 7, 2023 · 1 comment · Fixed by #911
Labels
bug help wanted

Comments

@leonklingele
Copy link

Summary

G402 doesn't catch the following case:

var conf tls.Config
conf.InsecureSkipVerify = true

Steps to reproduce the behavior

See above. Alternatively, clone this code and remove the /* #nosec G402 */ annotation in line 658.

gosec version

Latest master (05a7bc585d22119c3bd99d6ed03248b7c83f77e4)

Go version (output of 'go version')

go version 1.19.4 linux/amd64

Operating system / Environment

NixOS 22.11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug help wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix the TLS config rule when parsing the settings from a variable securego/gosec
2 participants
@ccojocar @leonklingele