Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version Packages #130

Merged
merged 1 commit into from
Jul 28, 2023
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
41 changes: 0 additions & 41 deletions .changeset/css-exports.md

This file was deleted.

5 changes: 0 additions & 5 deletions .changeset/deps.md

This file was deleted.

7 changes: 0 additions & 7 deletions .changeset/dev-entries.md

This file was deleted.

7 changes: 7 additions & 0 deletions packages/cli/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
# @crackle/cli

## 0.12.4

### Patch Changes

- Updated dependencies [[`433a30f`](https://github.com/seek-oss/crackle/commit/433a30f5ac81a107083b8d1c24ab9999f6f33ea4), [`f52495d`](https://github.com/seek-oss/crackle/commit/f52495dfaf603ba8f4dd87fc516b5ddb5ad07bd6), [`2b57d2f`](https://github.com/seek-oss/crackle/commit/2b57d2f1cb84a2452c8a33c46dcb42b58becb095)]:
- @crackle/core@0.28.0

## 0.12.3

### Patch Changes
Expand Down
4 changes: 2 additions & 2 deletions packages/cli/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@crackle/cli",
"version": "0.12.3",
"version": "0.12.4",
"license": "MIT",
"author": "SEEK",
"exports": {
Expand Down Expand Up @@ -33,7 +33,7 @@
"dev": "crackle dev"
},
"dependencies": {
"@crackle/core": "^0.27.1",
"@crackle/core": "^0.28.0",
"yargs": "^17.6.2"
},
"devDependencies": {
Expand Down
50 changes: 50 additions & 0 deletions packages/core/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,5 +1,55 @@
# @crackle/core

## 0.28.0

### Minor Changes

- [#128](https://github.com/seek-oss/crackle/pull/128) [`433a30f`](https://github.com/seek-oss/crackle/commit/433a30f5ac81a107083b8d1c24ab9999f6f33ea4) Thanks [@mrm007](https://github.com/mrm007)! - Crackle now supports importing external CSS.

This is useful when consuming packages which come with their own CSS, such as [Pure React Carousel](https://github.com/express-labs/pure-react-carousel).

External CSS can be imported with a side-effect `import`, same as how you would import a JavaScript or TypeScript module:

```tsx
// src/components/MyComponent.tsx
import 'package-with-styles/dist/styles.css';

import { Component } from 'package-with-styles';

export const MyComponent = (props) => {
<Component {...props} />;
};
```

The side-effect import will be preserved in the output bundles.

External CSS can also be imported with a CSS `@import` rule:

```css
/* src/components/MyComponent/third-party.css */
@import 'package-with-styles/dist/styles.css';
```

```tsx
// src/components/MyComponent.tsx
import './third-party.css';

export const MyComponent = () => {
// ...
};
```

When importing with a CSS `@import` rule, Crackle will bundle all external CSS into one file and output it to the `dist` directory.
Package exports will also be updated so consumers can import the bundled CSS.

- [#127](https://github.com/seek-oss/crackle/pull/127) [`f52495d`](https://github.com/seek-oss/crackle/commit/f52495dfaf603ba8f4dd87fc516b5ddb5ad07bd6) Thanks [@mrm007](https://github.com/mrm007)! - Update dependencies

### Patch Changes

- [#129](https://github.com/seek-oss/crackle/pull/129) [`2b57d2f`](https://github.com/seek-oss/crackle/commit/2b57d2f1cb84a2452c8a33c46dcb42b58becb095) Thanks [@mrm007](https://github.com/mrm007)! - Correctly resolve module exports when running `crackle dev`

This fixes an issue where `crackle dev` would not resolve an entry's exports when the entry re-exported from another module using `export * from ...` syntax.

## 0.27.1

### Patch Changes
Expand Down
2 changes: 1 addition & 1 deletion packages/core/package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@crackle/core",
"version": "0.27.1",
"version": "0.28.0",
"license": "MIT",
"author": "SEEK",
"sideEffects": false,
Expand Down
2 changes: 1 addition & 1 deletion pnpm-lock.yaml

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.