-
Notifications
You must be signed in to change notification settings - Fork 498
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't set font-family #50
Comments
The font-family which appears to be used is the same as the default
Time? Sure, changing the line where it sets the font-family. |
@kevin-brown I might not see the forest for the trees right now, but I think @amastaneh is right – select2-bootstrap-theme should just inherit |
You're right, one thing I forgot about this is that most people using Bootstrap are using the compiled files and not the source files - so the Bootstrap variable we use for the font family is never actually being changed. Considering that, it makes sense to not override the font family on our side. |
@kevin-brown 👍 - will be taken care of in the next release. |
Fixed in 0.1.0-beta.9. |
I think it's not recommended and it's not required that change font-family of select item because
select2.css
has not change any font-familyThe text was updated successfully, but these errors were encountered: