diff --git a/java/src/org/openqa/selenium/grid/node/config/SessionCapabilitiesMutator.java b/java/src/org/openqa/selenium/grid/node/config/SessionCapabilitiesMutator.java index e1efabcf18f4b..e542f3b89c7ee 100644 --- a/java/src/org/openqa/selenium/grid/node/config/SessionCapabilitiesMutator.java +++ b/java/src/org/openqa/selenium/grid/node/config/SessionCapabilitiesMutator.java @@ -96,10 +96,11 @@ private Map mergeChromiumOptions(Map stereotypeO Map capsOptions) { Map toReturn = new HashMap<>(stereotypeOptions); - for (String name : capsOptions.keySet()) { + for (Map.Entry entry : capsOptions.entrySet()) { + String name = entry.getKey(); + Object value = entry.getValue(); if (name.equals("args")) { - List arguments = - (List) (capsOptions.getOrDefault(("args"), new ArrayList<>())); + List arguments = (List) value; List stereotypeArguments = (List) (stereotypeOptions.getOrDefault(("args"), new ArrayList<>())); @@ -113,7 +114,7 @@ private Map mergeChromiumOptions(Map stereotypeO } if (name.equals("extensions")) { - List extensionList = (List) (capsOptions.get(("extensions"))); + List extensionList = (List) value; List stereotypeExtensions = (List) (stereotypeOptions.getOrDefault(("extensions"), new ArrayList<>())); @@ -128,7 +129,7 @@ private Map mergeChromiumOptions(Map stereotypeO } if (!name.equals("binary") && !name.equals("extensions") && !name.equals("args")) { - toReturn.put(name, capsOptions.get(name)); + toReturn.put(name, value); } } @@ -139,11 +140,11 @@ private Map mergeFirefoxOptions(Map stereotypeOp Map capsOptions) { Map toReturn = new HashMap<>(stereotypeOptions); - for (String name : capsOptions.keySet()) { + for (Map.Entry entry : capsOptions.entrySet()) { + String name = entry.getKey(); + Object value = entry.getValue(); if (name.equals("args")) { - List - arguments = - (List) (capsOptions.getOrDefault(("args"), new ArrayList<>())); + List arguments = (List) value; List stereotypeArguments = (List) (stereotypeOptions.getOrDefault(("args"), new ArrayList<>())); arguments.forEach(arg -> { @@ -155,8 +156,7 @@ private Map mergeFirefoxOptions(Map stereotypeOp } if (name.equals("prefs")) { - Map prefs = - (Map) (capsOptions.getOrDefault(("prefs"), new HashMap<>())); + Map prefs = (Map) value; Map stereotypePrefs = (Map) (stereotypeOptions.getOrDefault(("prefs"), new HashMap<>())); @@ -166,15 +166,12 @@ private Map mergeFirefoxOptions(Map stereotypeOp } if (name.equals("profile")) { - String rawProfile = - (String) capsOptions.get("profile"); - + String rawProfile = (String) value; toReturn.put("profile", rawProfile); } if (name.equals("log")) { - Map logLevelMap = - (Map) capsOptions.get("log"); + Map logLevelMap = (Map) value; toReturn.put("log", logLevelMap); } }