[java] remove requiredCapabilities from metadata ignored list

SeleniumHQ · Jan 5, 2024 · b5ae3f8 · b5ae3f8
1 parent b74d940
commit b5ae3f8
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 22 deletions.
diff --git a/java/src/org/openqa/selenium/remote/NewSessionPayload.java b/java/src/org/openqa/selenium/remote/NewSessionPayload.java
@@ -251,8 +251,7 @@ public Set<Dialect> getDownstreamDialects() {
   }
 
   public Map<String, Object> getMetadata() {
-    Set<String> ignoredMetadataKeys =
-        Set.of("capabilities", "requiredCapabilities");
+    Set<String> ignoredMetadataKeys = Set.of("capabilities");
 
     try (Reader reader =
             new InputStreamReader(backingStore.asByteSource().openBufferedStream(), UTF_8);

diff --git a/java/test/org/openqa/selenium/remote/NewSessionPayloadTest.java b/java/test/org/openqa/selenium/remote/NewSessionPayloadTest.java
@@ -27,7 +27,6 @@
 import static org.assertj.core.api.Assertions.assertThat;
 import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
 import static org.junit.jupiter.api.Assertions.assertEquals;
-import static org.junit.jupiter.api.Assertions.assertNull;
 import static org.openqa.selenium.json.Json.MAP_TYPE;
 
 import com.google.common.collect.ImmutableMap;
@@ -196,23 +195,6 @@ void forwardsMetaDataAssociatedWithARequest() throws IOException {
     }
   }
 
-  @Test
-  void doesNotForwardRequiredCapabilitiesAsTheseAreVeryLegacy() throws IOException {
-    try (NewSessionPayload payload =
-        NewSessionPayload.create(
-            ImmutableMap.of(
-                "capabilities",
-                EMPTY_MAP,
-                "requiredCapabilities",
-                singletonMap("key", "so it's not empty")))) {
-      StringBuilder toParse = new StringBuilder();
-      payload.writeTo(toParse);
-      Map<String, Object> seen = new Json().toType(toParse.toString(), MAP_TYPE);
-
-      assertNull(seen.get("requiredCapabilities"));
-    }
-  }
-
   @Test
   void shouldPreserveMetadata() throws IOException {
     Map<String, Object> raw =
@@ -263,8 +245,7 @@ void nullValuesInMetaDataAreIgnored() {
   void keysUsedForStoringCapabilitiesAreIgnoredFromMetadata() {
     Map<String, Object> raw =
         ImmutableMap.of(
-            "capabilities", singletonMap("alwaysMatch", singletonMap("browserName", "cheese")),
-            "desiredCapabilities", emptyMap());
+            "capabilities", singletonMap("alwaysMatch", singletonMap("browserName", "cheese")));
 
     try (NewSessionPayload payload = NewSessionPayload.create(raw)) {
       Map<String, Object> seen = payload.getMetadata();