Skip to content

Commit

Permalink
[java] Allow setting print options page ranges using list
Browse files Browse the repository at this point in the history
  • Loading branch information
pujagani committed Nov 21, 2023
1 parent c049595 commit eaaa502
Show file tree
Hide file tree
Showing 2 changed files with 16 additions and 0 deletions.
7 changes: 7 additions & 0 deletions java/src/org/openqa/selenium/print/PrintOptions.java
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,9 @@

package org.openqa.selenium.print;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;
import org.openqa.selenium.internal.Require;

Expand Down Expand Up @@ -71,6 +73,11 @@ public void setPageRanges(String firstRange, String... ranges) {
}
}

public void setPageRanges(List<String> ranges) {
this.pageRanges = new String[ranges.size()];
this.pageRanges = ranges.toArray(this.pageRanges);
}

public void setBackground(boolean background) {
this.background = Require.nonNull("background", background);
}
Expand Down
9 changes: 9 additions & 0 deletions java/test/org/openqa/selenium/print/PrintOptionsTest.java
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@

import static org.assertj.core.api.Assertions.assertThat;

import java.util.List;
import java.util.Map;
import org.junit.jupiter.api.Tag;
import org.junit.jupiter.api.Test;
Expand Down Expand Up @@ -48,6 +49,14 @@ void setsValuesAsPassed() {
assertThat(printOptions.getShrinkToFit()).isFalse();
}

@Test
void setsPageRanges() {
PrintOptions printOptions = new PrintOptions();

printOptions.setPageRanges(List.of("1-2", "6-7"));
assertThat(printOptions.getPageRanges().length).isEqualTo(2);
}

@Test
void toMapContainsProperKey() {
PrintOptions printOptions = new PrintOptions();
Expand Down

0 comments on commit eaaa502

Please sign in to comment.