You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
So the readme says setup will use the command semantic-release || true for CircleCI...
But it sucks to realize a month later that a build failed to publish even though it passed.
When you think about it, the || true seems questionable on its face. I forget why it's recommended but I'm guessing semantic-release has a nonzero exit code when the branch is excluded.
I think there should be a CLI flag to suppress the nonzero exit code when appropriate, so that we can avoid using || true.
EDIT: Just realized I'm on version 15, maybe semantic-release 17 notifies us if the release is failing?
The text was updated successfully, but these errors were encountered:
So the readme says setup will use the command
semantic-release || true
for CircleCI...But it sucks to realize a month later that a build failed to publish even though it passed.
When you think about it, the
|| true
seems questionable on its face. I forget why it's recommended but I'm guessingsemantic-release
has a nonzero exit code when the branch is excluded.I think there should be a CLI flag to suppress the nonzero exit code when appropriate, so that we can avoid using
|| true
.EDIT: Just realized I'm on version 15, maybe semantic-release 17 notifies us if the release is failing?
The text was updated successfully, but these errors were encountered: