Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sendgrid_Translator::get_smtp_filter_settings() shouldn't ignore disabled filter settings #421

Closed
thomasbachem opened this issue Aug 16, 2017 · 1 comment
Labels
status: duplicate duplicate issue

Comments

@thomasbachem
Copy link

As of now, disabled filters on a V2 object get ignored when translating them to the V3 object – but I explicitly want to disable a default filter.

This needs to be removed from Sendgrid_Translator::get_smtp_filter_settings():

// If it's not enabled, return empty array, no need to make the payload bigger
if ( ! $email_v2->smtpapi->filters[ $filter_key ][ $filter_sub_label ][ $filter_enabled ]  ) {
  return $output_array;
}

See also #420.

@thomasbachem thomasbachem changed the title Sendgrid_Translator::get_smtp_filter_settings() shouldn't ignore "disabled" filter settings Sendgrid_Translator::get_smtp_filter_settings() shouldn't ignore disabled filter settings Aug 16, 2017
@thinkingserious thinkingserious added the status: duplicate duplicate issue label Aug 16, 2017
@thinkingserious
Copy link
Contributor

I think #387 will also solve this. Please let me know if this is not the case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
status: duplicate duplicate issue
Projects
None yet
Development

No branches or pull requests

2 participants