Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure text/plain is always the first object among multiple Content objects #608

Closed
thinkingserious opened this issue May 19, 2018 · 2 comments
Closed

Ensure text/plain is always the first object among multiple Content objects #608

thinkingserious opened this issue May 19, 2018 · 2 comments
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap

Comments

@thinkingserious
Copy link
Contributor

Issue Summary

The SendGrid API requires that a MimeType of "text/plain" should always be first in an array of Content objects, when specified. Our examples currently demonstrate this, but we should ensure that this is the case in the SDK in the event that someone sets "text/html" (for example) as the first Content object. The update should be made in the Mail object, getContents method.
@thinkingserious thinkingserious added status: help wanted requesting help from the community difficulty: easy fix is easy in difficulty up-for-grabs type: twilio enhancement feature request on Twilio's roadmap labels May 19, 2018
@hjmsw
Copy link
Contributor

hjmsw commented Jun 8, 2018

@thinkingserious Happy to give this a go!

@thinkingserious
Copy link
Contributor Author

Awesome, thank you @hjamesw93!

@hjmsw hjmsw mentioned this issue Jun 8, 2018
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: help wanted requesting help from the community type: twilio enhancement feature request on Twilio's roadmap
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@thinkingserious @hjmsw @childish-sambino