Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Code Review to Contributing.md #267

Closed
thinkingserious opened this issue Oct 31, 2017 · 1 comment · Fixed by #268
Closed

Add Code Review to Contributing.md #267

thinkingserious opened this issue Oct 31, 2017 · 1 comment · Fixed by #268
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: docs update documentation change not affecting the code

Comments

@thinkingserious
Copy link
Contributor

  • Add a "Code Reviews" section on CONTRIBUTING.md
  • Put the following under the header:

If you can, please look at open PRs and review them. Give feedback and help us merge these PRs much faster! If you don't know how, Github has some great information on how to review a Pull Request.

  • Link the header in the Contributing.md Table of Contents
  • Add a link to the README.md file: Review Pull Requests under "Contributing Section"
@thinkingserious thinkingserious added difficulty: easy fix is easy in difficulty hacktoberfest labels Oct 31, 2017
@mptap mptap mentioned this issue Oct 31, 2017
Merged
6 tasks
@mptap
Copy link
Contributor

mptap commented Oct 31, 2017

@thinkingserious: PR: #268

@thinkingserious thinkingserious added status: work in progress Twilio or the community is in the process of implementing type: docs update documentation change not affecting the code labels Mar 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
difficulty: easy fix is easy in difficulty status: work in progress Twilio or the community is in the process of implementing type: docs update documentation change not affecting the code
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Added Code Review to Contributing.md mptap/sendgrid-ruby
2 participants
@thinkingserious @mptap