Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

small documentation error #3237

Closed
notestaff opened this issue Feb 22, 2024 · 2 comments · Fixed by #3238
Closed

small documentation error #3237

notestaff opened this issue Feb 22, 2024 · 2 comments · Fixed by #3238

Comments

@notestaff
Copy link

At

/*!\brief A static variable indicating the number of threads to use for the bgzf-streams. Defaults to 4.

the variable is no longer static.

Also, maybe doc/cookbook/compression_threads.cpp should include this file, rather than seqan3/io/all.hpp? Or this file is not part of the public API?

@SGSSGene
Copy link
Contributor

SGSSGene commented Feb 23, 2024

Thank you! This is a mistake in the documentation. PR #3238 will fix this.
bgzf_thread_count is meant to be used to change number of threads being used.

About the include path, I am not so sure, I will discuss this with the others.

@eseiler
Copy link
Member

eseiler commented Feb 23, 2024

The contrib include is completely non-API.

But you don't need io/all.hpp either.
If you only use a specific io, it is enough to include that.

Any IO that supports compression will implicitly include this bgzf header.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants