Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Decide whether to version codegen/macros separately from serde #376

Closed
dtolnay opened this issue Jun 11, 2016 · 3 comments
Closed

Decide whether to version codegen/macros separately from serde #376

dtolnay opened this issue Jun 11, 2016 · 3 comments
Assignees

Comments

@dtolnay
Copy link
Member

dtolnay commented Jun 11, 2016

We can keep them in the same repository, but do we need to continue tying their version numbers together? It often happens that we change codegen/macros and cut a release in which serde hasn't changed at all, or vice versa.

@dtolnay
Copy link
Member Author

dtolnay commented Aug 19, 2016

We can reopen if anyone has a strong opinion. For now I think serde and serde_codegen make breaking changes infrequently enough that tying the versions is not a problem.

@dtolnay dtolnay closed this as completed Aug 19, 2016
@dtolnay
Copy link
Member Author

dtolnay commented Sep 27, 2016

Reopening to discuss the possibility of releasing serde_codegen 0.9 while staying with serde 0.8. I need to fix the cargo version issue (#543) in order to make progress on serde_derive (#548). This would be a breaking change for serde_codegen but there is no real motivation for breaking core serde right now - the enum API I guess (#523) but that can wait.

Another option is to go all-in on Macros 1.1. Basically take all the code currently in serde_codegen and fold it into serde_derive, then delete serde_codegen and serde_macros from the codebase and never release another version of them. In the event that someone demands a codegen bug fixed on stable, we can fix it on an old 0.8 branch.

@erickt @oli-obk

@dtolnay dtolnay reopened this Sep 27, 2016
@dtolnay
Copy link
Member Author

dtolnay commented Sep 27, 2016

Never mind, I think I can work around it for now in serde_codegen as long as I fix it in syntex/quasi/aster, which is easier.

@dtolnay dtolnay closed this as completed Sep 27, 2016
@dtolnay dtolnay self-assigned this Apr 9, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

No branches or pull requests

1 participant