New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clean up workarounds from syn conversion #562

Closed

dtolnay opened this issue Sep 27, 2016 · 0 comments

Assignees

Labels

code quality derive

Member

dtolnay commented Sep 27, 2016

Per #548 (comment)

There were a few places that I uncovered strange behavior in the old codegen (just unusually placed semicolons / parentheses / braces) that I went out of my way to preserve. I left comments and I can clean that up in a separate PR. I confirmed that this PR expands the test suite byte-for-byte identical to master.

dtolnay added derive code quality labels

dtolnay self-assigned this

This was referenced Sep 27, 2016

No more syntex for serde_derive #548

Merged

Clean up syn workarounds #564

Merged

dtolnay closed this as completed in #564

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment