Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Checks dropdown may fail to display checks #89

Open
julen opened this issue Nov 13, 2016 · 0 comments
Open

Checks dropdown may fail to display checks #89

julen opened this issue Nov 13, 2016 · 0 comments
Labels

Comments

@julen
Copy link
Contributor

julen commented Nov 13, 2016

Steps to reproduce:

  1. Open the editor in a context where there are no failing checks, but trigger the checks UI with .../translate/#filter=checks. At this point no failing checks are displayed.
  2. Change the filter to something else, e.g. All
  3. Perform a translation which triggers any type of check failure.
  4. Select Checks from the filtering options.

Observed:
The failing check is not displayed in the drop-down.

Expected:
The failing check is displayed in the drop-down.

Note this was also the case before (as already commented in #80 (comment)) but now it becomes a bit more prominent as selecting Checks allows to browse through all checks, and the UI expands too.

The problem is that elements are removed from the DOM (motivated because hiding option elements doesn't work reliably across browsers), so after that event they won't be available again until a full page refresh. Ideally we should be able to declaratively specify the check groups and checks we want to display, and don't worry about the DOM at all.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant