Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Desktop support by adding ComposablePreviewScanner dependency instead of copy-pasting code from :core and :jvm #3

Closed
sergio-sastre opened this issue Jun 12, 2024 · 1 comment
Labels
help wanted Extra attention is needed release 0.2.0

Comments

@sergio-sastre
Copy link
Owner

sergio-sastre commented Jun 12, 2024

Due to this issue #1 in 0.1.0 caused due to missing Compose Runtime, I've made all modules, :core, :android and :jvm "android libs" as first step, so it can be used in Android projects.

However, this also means that the :jvm module cannot be used in Desktop-Compose projects.
The right solution is to make :core and :jvm modules support multiplatform.

From the dependency perspective, it should be possible, but I'm lacking experience in releasing Kotlin multiplatform libraries, and need to research how to overcome the compose runtime problem in the :core module.

This is likely not going to happen before 8th July.

If anybody has experience with it, feel free to open a PR :)
I'd appreciate some help :)

WORKAROUND
For now, the workaround is to copy the code of the :core and :jvm folders in your compose-desktop project and add the missing dependencies

    testImplementation 'org.jetbrains.kotlin:kotlin-reflect:1.9.22'
    testImplementation 'io.github.classgraph:classgraph:4.8.173'

and that should solve it.

@sergio-sastre sergio-sastre added the help wanted Extra attention is needed label Jun 12, 2024
@sergio-sastre sergio-sastre changed the title Enable Desktop support by adding ComposablePreviewScanner dependency Enable Desktop support by adding ComposablePreviewScanner dependency instead of copy-pasting code from :core and :jvm Jun 13, 2024
@sergio-sastre
Copy link
Owner Author

should be solved in 0.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed release 0.2.0
Projects
None yet
Development

No branches or pull requests

1 participant