Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Chaining DevicePreviewInfoParser calls to inDp() and inPx() several times does not return the expected value #42

Closed
sergio-sastre opened this issue Jan 31, 2025 · 0 comments · Fixed by #43
Closed

Chaining DevicePreviewInfoParser calls to inDp() and inPx() several times does not return the expected value #42

sergio-sastre opened this issue Jan 31, 2025 · 0 comments · Fixed by #43
Labels
bug Something isn't working release 0.5.1

Comments

@sergio-sastre
Copy link
Owner

This is also a rare case but calling DevicePreviewInfoParser.parse(deviceId).inDp().inPx().inDp() does not return the expected value
That's because when converting by calling inPx() returns unit Dpinstead of Px, so post calls convert incorrectly
@sergio-sastre sergio-sastre added bug Something isn't working release 0.5.1 labels Jan 31, 2025
@sergio-sastre sergio-sastre linked a pull request Feb 1, 2025 that will close this issue
Fix conversion error when using device.inPx() #43
Merged
@sergio-sastre sergio-sastre mentioned this issue Feb 12, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working release 0.5.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix conversion error when using device.inPx() sergio-sastre/ComposablePreviewScanner
1 participant
@sergio-sastre