Update Microsoft.Azure.EventHubs 1.0.3 to 4.3.1 #23
Conversation
Updates the main dependency to the latest version of the event hub SDK. Without this change the sink will not work on .net5 as the sink throws a silent exception. v1 of the event hub SDK is 4 years old so probably lots of other improvements, including better support AMQP
|
The build is failing because of the net451 support which mandates the 1.0.3 of the dependency. Perhaps a conditional reference could be used so that it defaults to 4.3.1 if you are on netstandard2.0 ? |
|
We've experienced the same issue, and are interested in this PR. Wondering if you got any feedback from the repo owner? |
|
No, just what you see here. I forced the upgraded dependency locally by installing the new version of the eventhub sdk in my app and that fixes the issue, while we wait for this upstream fix. |
|
I see. One way to fix this issue could be to specify different dependencies for net451 and netstandard2.0, which I guess you are suggesting? @nblumhardt , what is your opinion on this? Here is more info on the issue we're facing: Azure/azure-amqp#165 |
|
Thanks for the PR! Sorry about the lack of response - I haven't worked on this codebase for quite some time. I think dropping .NET 4.5 support would make sense at this stage. |
|
@nblumhardt so you think we should remove net451 from target framework? Seems reasonable. @alastairtree do you have time to push this change? Not sure if I have the permission to edit your branch. |
|
I have removed 451, and incremented the version to 6.0, and hopefully fixed the build failures |
|
Just updated the NuGet.org publishing key - |
|
@nblumhardt I dont think this ever made it to nuget.org? https://www.nuget.org/packages/Serilog.Sinks.AzureEventHub/ |
|
@nblumhardt is a release version of the package going to be produced? Its been out as a prerelease package for a while now. |
Updates the main dependency to the latest version of the event hub SDK.
Without this change the sink will not work on .net5 as the sink throws a silent exception.
v1 of the event hub SDK is 4 years old so probably lots of other improvements, including better support AMQP