Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use blockada optimized version #81

Closed
wants to merge 1 commit into from

Conversation

SpencerIsGiddy
Copy link
Contributor

@SpencerIsGiddy SpencerIsGiddy commented Dec 1, 2022

Reduces # of entries by a lot. Potentially leaving room for other blocklists to be added to the service in the future. Although not important. Reduces entries by a little less then 90% i believe

Another thing is that I personally do not use the ublock filter list as I find it too aggressive and broke twitter last time I used the list so I do not use it. I wonder if the optimized version is less aggressive.

@ignoramous
Copy link
Contributor

The Blokada version lists exist because I presume Blokada is pretty bad at dealing with large list, which isn't a problem for Rethink or serverless-dns. In fact, the more blocklists we add, the better our compression gets (to an extent).

I'd be wary of using a list that's optimised for a deficient app. Has the list maintainer mentioned just how the version is really optimized? If it is removing wildcards, then they should call it wildcard list like other maintainers do.

@SpencerIsGiddy
Copy link
Contributor Author

To me, the only difference other than the amount of entries is that the Blokada optimized version includes the host and then the wildcard entry of the host. While the normal version is just hosts

@ignoramous
Copy link
Contributor

ignoramous commented Dec 4, 2022

That "optimization" is already enabled for all blocklists before building the final blocklists in serverless-dns code. I'd rather not use a list built specifically for one rather lousy dns app :)

@SpencerIsGiddy
Copy link
Contributor Author

Ok👍

@SpencerIsGiddy
Copy link
Contributor Author

So I’m reopening this pull request because I talked with the developer of the list and he says that both hosts.txt and hosts_blokada.txt sources are from the same sources. It’s just the format difference mtxadmin/ublock#54

Does this change anything?

@ignoramous
Copy link
Contributor

ignoramous commented Jan 13, 2023

Thanks. Nothing changes from what I can tell. In fact, as mentioned above, Rethink is more efficient with larger lists.

@SpencerIsGiddy
Copy link
Contributor Author

Thanks. Nothing changes from what I can tell. In fact, as mentioned above, Rethink is more efficient with larger lists.

Sounds good👍

@mtxadmin
Copy link
Contributor

I think, main advantage of asterisk-driven form is flexibility. Ability to block any future subdomains (as for me as a blocklist maintainer it is wow! A killer feature!)

For instance, well-known doubleclick domains:

Traditional format:

doubleclick.net
1016557.fls.doubleclick.net
1268402.fls.doubleclick.net
1295336.fls.doubleclick.net
1326154.fls.doubleclick.net
1330903.fls.doubleclick.net
1359940.fls.doubleclick.net
1412173.fls.doubleclick.net
1435575.fls.doubleclick.net
1513878.fls.doubleclick.net
1742177.fls.doubleclick.net
2013561.fls.doubleclick.net
2196503.fls.doubleclick.net
2332696.fls.doubleclick.net
2463678.fls.doubleclick.net
2499034.fls.doubleclick.net
...
...
... and counting

And with asterisks:

doubleclick.net
*.doubleclick.net

The thing is, an ad network can make 100500 another random subdomains, and traditional form won't catch them. At the same time, asterisk form will block any new subdomains, without interaction from anyone.

@ignoramous
Copy link
Contributor

Rethink treats all blocklists as if they were wildcards and removes duplicates (:

In fact this is what AdGuard also does, because like you say, it simply makes sense.

@mtxadmin
Copy link
Contributor

It is really makes sense.

https://rethinkdns.com : "paid plans launching soon." "With our paid plans (coming soon), you'll also be able to define your own custom blocklists"

Blokada initially was more free :-(

But dns blocker + firewall is a unique combo. Please, let me know when paid plans will be available. At least, I add RethinkDNS to the docs. Thanks in advance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants