-
Notifications
You must be signed in to change notification settings - Fork 417
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unexpected Token ... #233
Comments
Hi @radelcom , thanks for submitting the issue ;-) The warnings are unrelated to the issue, and the property 1 bug too - these were/are completely different ones. But it is strange that the Node version makes a difference. There should be no code at all in the plugin that uses functionality that is only available in Node 8 (we use Node 6 everywhere at work to replicate the behavior on the AWS Lambda runtime and I never saw the issue). Can you try to upgrade or downgrade the SLS version, just to make sure that it is independent from that? I remember that there was a discussion of using graceful-fs in SLS, which impacts all plugins loaded in the SLS process, but I'm not sure if that can have anything to do with the issue. The stacktrace shows that it already crashes during a const BbPromise = require('bluebird');
const path = require('path');
const fse = require('fs-extra');
const glob = require('glob');
const lib = require('./index');
const _ = require('lodash'); What I can try to do is, to update these dependencies to the most recent versions and we can check if the problem is gone. |
Just another guess: Currently the plugin does not explicitly tell if the config load failed, but just emits the error. I will change that for the next release, so that it is clear, where exactly the failure occurs. |
I added an extra log line in case the configuration file cannot be loaded in #234 , so that it is clear, if an error is located in the config or in the plugin. Can you try to use the PR version and check if the crash is originating from the plugin or the config? |
Hi @HyperBrain, Thanks for the speedy response. It turns out, I think it is more related to the boilerplate template I was using serverless-es7. Instead, I followed the sample setup in babel-dynamically-entries and it seems to be working fine now in node v6.10.x |
Glad to hear that the issue is solved 👍 . I will merge the log changes I did so that they are in the next release. Then it will show the reason for these issues right away. |
This is a Bug Report
Description
I started getting this error message when doing
sls deploy
. I was digging around and narrowed it down. It seems like dependent on which node version I am using. I am using nvm as my node version manager. If I use node v6.10.3, I get this issue and if I switched to node v8.4.0, all goes away and deploys successfully.I guess follow up question is, is it ok to use node v8.4.0 during development and wont have impact to the actual supported node v6.10 version in AWS when serverless is deployed?
Any input is greatly appreciated. tx in advance!
Similar or dependent issue(s):
Additional Data
serverless: v1.21.1
serverless-webpack: v3.0.0
webpack: v3.0.0
node: v6.10.3
The text was updated successfully, but these errors were encountered: