Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Compiled regex should be a private global variable to avoid being recompiled #20

Open
ghostsquad opened this issue Oct 31, 2020 · 1 comment
Open

Compiled regex should be a private global variable to avoid being recompiled #20

ghostsquad opened this issue Oct 31, 2020 · 1 comment

Comments

@ghostsquad
Copy link

multibar/multibar.go

Line 166 in 4bf4cf7

re, err := regexp.Compile(`(\d+).(\d+)(\w+)`)

@ghostsquad ghostsquad changed the title Compiled regex should be part of the multibar constructor to avoid recompiling at every call Compiled regex should be a local global variable to avoid being recompiled Oct 31, 2020
@ghostsquad ghostsquad changed the title Compiled regex should be a local global variable to avoid being recompiled Compiled regex should be a private global variable to avoid being recompiled Oct 31, 2020
@sethgrid
Copy link
Owner

sethgrid commented Nov 3, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ghostsquad @sethgrid