Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect failure message displayed #149

Closed
arnoldtaw opened this issue May 7, 2024 · 4 comments
Closed

Incorrect failure message displayed #149

arnoldtaw opened this issue May 7, 2024 · 4 comments
Assignees
Labels
bug Something isn't working waiting feedback Waiting on feedback from requestor
Milestone

Comments

@arnoldtaw
Copy link

Describe the bug
Upon detecting a failure, the correct failure message was not displayed. Instead, it displayed the placeholder text.
Placeholder message; update in the 'finalise' function

To Reproduce
Unable to reproduce consistently. Correct customized failure message was displayed in most cases. Once in a while, we will get this message.

Expected behavior
Upon detecting a failure, display the correct failure message.

Code/log output
N/A

Screenshots
Screenshot 2024-05-07 at 8 26 23 AM

Environment:

  • macOS 14.4.1
  • Script version 1.14.2
  • swiftDialog 2.4.2
@arnoldtaw arnoldtaw added the bug Something isn't working label May 7, 2024
Copy link

I'm consistently running into this bug. Glad it's already been identified. Happy to assist with troubleshooting.

@jcmbowman
Copy link

Fixed on my end by changing sleep time to 0.7 here:

eval "${dialogFailureCMD}" & sleep 0.3

@dan-snelson
Copy link
Collaborator

@arnoldtaw: While I'm aware of other reports of this unexpected behavior, I'm not able to replicate it.

That said, please advise if 1.15.0-b7 resolves the issue.

Thanks.

@dan-snelson dan-snelson added this to the 1.15.0 milestone May 28, 2024
@dan-snelson dan-snelson added the waiting feedback Waiting on feedback from requestor label May 28, 2024
@dan-snelson
Copy link
Collaborator

Addressed in SYM 1.15.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working waiting feedback Waiting on feedback from requestor
Projects
None yet
Development

No branches or pull requests

3 participants