-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pointcloud support #6
Comments
It's definitely possible, and functionality I want to have. But I haven't tried it yet, and I'm not sure how much time I'll have to in the near future. If you want to give it a shot by all means! I imagine the code would be quite similar to |
Thanks! I will take a look! |
Started working on this this weekend.. close to releasing a new version whenever I have a few hours to refactor and release |
I did some work on this last week: https://github.com/haehn/DracoPy maybe its helpful |
Encoding works already |
That's funny, we ended up doing almost exactly the same thing, whoops 😅. Sorry I hope you didn't spend too much time on this. In this branch decoding and encoding works: https://github.com/seung-lab/DracoPy/tree/point_cloud_support I just want to refactor it to reduce the duplicate code (working with meshes and point clouds are quite similar) before releasing it Thank you for your help! |
That is funny. Thanks! I do need generic point cloud support - not only x,y,z data. Will you include that as well? |
I'm planning on adding support for Generic, Texture, and Color attributes next after this. Not sure when exactly I'll be able to since I can only really work on this nights and weekends. Like before, feel free to give it a try. |
I added support for generic encoding and for sequential point cloud encoding by modifying your code. Not the cleanest but it works :) |
Cool beans! By the way I refactored the code and published a new version to PyPI, so v0.0.14 is live with the point cloud support |
Hi @haehn, I couldn't tell from this discussion if all the features you wanted were included in 0.0.14. Would you still like to proceed with the PR? |
Any update on this? DracoPy in this repo doesn't seem to read in color data from point clouds. |
I think color data is probably a kind of metadata. We have a PR for metadata here: #20 I think we do have support for decoding point cloud geometry, but it's only the geometry. |
I believe this is now in DracoPy. |
Hi,
Would it be possible to also wrap
encoder->EncodePointCloudToBuffer
? Did you try it already?Thanks so much!
Daniel
The text was updated successfully, but these errors were encountered: