Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

capistrano v3.1 compatible improve: dependency solve #22

Merged
merged 1 commit into from
Dec 30, 2013

Conversation

crhan
Copy link
Collaborator

@crhan crhan commented Dec 27, 2013

@@ -91,6 +87,7 @@ namespace :puma do
invoke 'puma:restart'
end
end
after 'deploy:finished', 'puma:smart_restart'
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the advantage of this refactoring ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  1. in capistrano 3.1, after and before will immediately looking for the given task(see commit capistrano/capistrano@a58bb3b). That makes the after hook must be invoked after the task declared
  2. make 4 lines to 1 line
  3. After capistrano 3.1, you can write after 'deploy:finished', :smart_restart here(without current namespace 'puma'). But for the backward compatible, still use full name here

seuros added a commit that referenced this pull request Dec 30, 2013
capistrano v3.1 compatible improve: dependency solve
@seuros seuros merged commit 1716222 into seuros:master Dec 30, 2013
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants