Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ardour 6.8 can't load the HEAD version of the LV2 and VST3 plugin #47

Closed
paulfd opened this issue Jul 23, 2021 · 1 comment · Fixed by sfztools/sfizz#995
Closed

Ardour 6.8 can't load the HEAD version of the LV2 and VST3 plugin #47

paulfd opened this issue Jul 23, 2021 · 1 comment · Fixed by sfztools/sfizz#995

Comments

@paulfd
Copy link
Member

paulfd commented Jul 23, 2021

The issue is with the symbol pango_font_metrics_get_height(...) which comes from libpango 1.44 and up. Ardour currently bundles in libpango 1.40.4. I added a pull request on our VSTGUI fork which includes a runtime check for the libpango version before calling this method. This solves the problem for the VST3 version, since Ardour calls dlopen with the RTDL_LAZY flag for VST plugins. However, this does not solve the issue for the LV2 plugin, because suil loads UIs with the RTDL_NOW flag and thus the UI fails to instantiate due to the missing symbol.

I think we should push the runtime check upstream in VSTGUI. To allow LV2 UIs, I think our solutions are either:

  • Remove the code from our VSTGUI fork and use it until Ardour updates libpango. I haven't seen a visual impact when disabling this part of the code to be honest, but I haven't checked deeply either.
  • Statically link in pango/cairo in the UI
@paulfd paulfd added the bug label Jul 23, 2021
@jpcima
Copy link
Contributor

jpcima commented Jul 27, 2021

Hi, I thought to have already fixed this in upstream vstgui.
I recall to have sent a PR after the vstgui author introduced this call, which indeed broke Ardour.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants