-
-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
cc140 treats keyswitch as previous note #1074
Comments
Thanks for the report; I'll check out the behavior of other implementations and correct it if necessary ! |
I check CC140 with keyswitches in sforzando. I think this is quite similar to last year issue, which is ARIA's behavior not excluding keyswitches range as notes range. |
Yes, Sforzando definitely behaves like this, ran into it with Turkish Rebab which keyswitches between legato and non-legato articulations, and the Hadzi-Fia and Hadzi-Hevi vocals which keyswitch between legato syllables. Haven't figured out a workaround of any sort yet, but can confirm this is ARIA behavior. |
Just checking again, |
@paulfd |
Is there any upside to having a keyswitch register as previous note for cc140? |
I don't think so. |
I can't think of an upside, either. If I really tried I could maybe think of some edge case where this would be an advantage, but that would be a rare and special usage, and it's definitely a downside for "normal" keyswitching legato instruments. |
I know it's almost gravedigging, sorry... To push this idea further, should any of the extended CC be changed by a keyswitch note? e.g. 131, 133, ... I've tried disabling them all in #1113 if someone wants to give it a shot! |
I won't get a chance to try it out for a while, but off the top of my head, absolutely a keyswitch note should NOT trigger any extended CCs. So I think that your thinking is correct here. |
I've been trying to simulate legato by using keyswitches.
Unreal Instruments Two Whistles has a "tongued" patch (named "Tanging") and
a "Fast legato" (Legato_Fast) patch, which creates a slight portamento into the main pitch based on cc140=30.
On a real instrument you might tongue the first note of a phrase to start the airflow and then moderate the airflow as you play subsequent legato notes in order to get them in tune. That's what I think the "Fast legato" tries to emulate.
Fast Legato works really well after the first note of the legato phrase, so the basic implementation is great. But if I hit the Fast Legato keyswitch first (obviously located at the other end of the keyboard from the sounding notes) I get a huge portamento into the first note.
Likewise if I hit the Tang keyswitch, play a note, hit the Fast Legato keyswitch and play another note I get the same huge portamento.
So it seems that cc140 is treating the keyswitch as the note number it uses to calculate the pitch delta.
Is it possible to only include notes that trigger samples so the note numbers of the keyswitches are ignored?
The text was updated successfully, but these errors were encountered: